fix: Fix a possible crash when parsing RBAC (#8165)

Signed-off-by: jannfis <jann@mistrust.net>
argoproj · Jan 13, 2022 · 5c85df9 · 5c85df9
1 parent 07cc533
commit 5c85df9
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/util/rbac/rbac.go b/util/rbac/rbac.go
@@ -470,6 +470,12 @@ func loadPolicyLine(line string, model model.Model) error {
 
 	key := tokens[0]
 	sec := key[:1]
+	if _, ok := model[sec]; !ok {
+		return fmt.Errorf("invalid RBAC policy: %s", line)
+	}
+	if _, ok := model[sec][key]; !ok {
+		return fmt.Errorf("invalid RBAC policy: %s", line)
+	}
 	model[sec][key].Policy = append(model[sec][key].Policy, tokens[1:])
 	return nil
 }