Skip to content

Commit

Permalink
Set cookie policy to SameSite=lax and httpOnly (#2498)
Browse files Browse the repository at this point in the history
  • Loading branch information
jannfis authored and Alexander Matyushentsev committed Oct 17, 2019
1 parent e8c21ab commit 8d5939f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion server/server.go
Expand Up @@ -486,7 +486,7 @@ func (a *ArgoCDServer) newGRPCServer() *grpc.Server {
// TranslateGrpcCookieHeader conditionally sets a cookie on the response.
func (a *ArgoCDServer) translateGrpcCookieHeader(ctx context.Context, w http.ResponseWriter, resp golang_proto.Message) error {
if sessionResp, ok := resp.(*sessionpkg.SessionResponse); ok {
flags := []string{"path=/"}
flags := []string{"path=/", "SameSite=lax", "httpOnly"}
if !a.Insecure {
flags = append(flags, "Secure")
}
Expand Down

0 comments on commit 8d5939f

Please sign in to comment.