-
Notifications
You must be signed in to change notification settings - Fork 5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: allow argocd-notification ingress to repo-server (#6746)
* Allow argocd-notification ingress to repo-server This change allows an argocd-notification installation using the provided manifests to ingress to the repo-server. I am not sure if there is a prevailing opinion about how to manage a cross project network policy for these related components so I thought I would put up a PR to spark that discussion. This could live in a separate NetworkPolicy object managed by the argocd-notifications manifests but I thought it wuold be better for the possible ingresses for the argocd project to all live in the argo-cd manifests. I know that notifications are an optional component, so maybe this is better provided as a separate manifest that can be strategic merged in? (I am a kustomize user). Regardless, I think this policy is something that be maintained by argoproj in some form to reduce release burden of users trying to hand maintain network policies. Signed-off-by: Tyler Dixon <tdixon@buf.build> * make manifests Signed-off-by: Tyler Dixon <tdixon@buf.build>
- Loading branch information
Showing
5 changed files
with
15 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters