Extracting constant and simplifying boolean expression

Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com>

common/common.go

@@ -117,9 +117,10 @@ const (
 	RoundRobinShardingAlgorithm = "round-robin"
 	// AppControllerHeartbeatUpdateRetryCount is the retry count for updating the Shard Mapping to the Shard Mapping ConfigMap used by Application Controller
 	AppControllerHeartbeatUpdateRetryCount = 3
-	// ConsistentHashingWithBoundedLoadsAlgorithm uses an algorithm that tries to use an equal distribution accross
-	// all shards but is optimised to handled sharding and/or cluster addings or removal. In case of sharding or
-	// cluster changes, this algorithm minimise the changes between shard and clusters assignments.
+
+	// ConsistentHashingWithBoundedLoadsAlgorithm uses an algorithm that tries to use an equal distribution across
+	// all shards but is optimised to handle sharding and/or cluster addition or removal. In case of sharding or
+	// cluster changes, this algorithm minimises the changes between shard and clusters assignments.
 	ConsistentHashingWithBoundedLoadsAlgorithm = "consistent-hashing"
 
 	DefaultShardingAlgorithm = LegacyShardingAlgorithm

controller/sharding/consistent/consistent.go

@@ -19,6 +19,11 @@ import (
 	blake2b "github.com/minio/blake2b-simd"
 )
 
+// OptimalExtraCapacityFactor extra factor capacity (1 + ε). The ideal balance
+// between keeping the shards uniform while also keeping consistency when
+// changing shard numbers.
+const OptimalExtraCapacityFactor = 1.25
+
 var ErrNoHosts = errors.New("no hosts added")
 
 type Host struct {
@@ -234,7 +239,7 @@ func (c *Consistent) MaxLoad() int64 {
 	if avgLoadPerNode == 0 {
 		avgLoadPerNode = 1
 	}
-	avgLoadPerNode = math.Ceil(avgLoadPerNode * 1.25)
+	avgLoadPerNode = math.Ceil(avgLoadPerNode * OptimalExtraCapacityFactor)
 	return int64(avgLoadPerNode)
 }
 
@@ -256,11 +261,7 @@ func (c *Consistent) loadOK(server string) bool {
 		panic(fmt.Sprintf("given host(%s) not in loadsMap", bserver.Name))
 	}
 
-	if float64(bserver.Load)+1 <= avgLoadPerNode {
-		return true
-	}
-
-	return false
+	return float64(bserver.Load)+1 <= avgLoadPerNode
 }
 
 func (c *Consistent) delSlice(val uint64) {

go.mod

@@ -209,8 +209,6 @@ require (
 	github.com/go-telegram-bot-api/telegram-bot-api/v5 v5.5.1 // indirect
 	github.com/golang/glog v1.1.2 // indirect
 	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
-	github.com/google/btree v1.1.2 // indirect
-	github.com/google/gnostic v0.6.9 // indirect
 	github.com/google/go-github/v41 v41.0.0 // indirect
 	github.com/google/go-github/v53 v53.2.0 // indirect
 	github.com/google/go-querystring v1.1.0 // indirect