Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose bcrypt as part of argocd #10050

Closed
jsoref opened this issue Jul 19, 2022 · 7 comments · Fixed by #10056 or #10934
Closed

Expose bcrypt as part of argocd #10050

jsoref opened this issue Jul 19, 2022 · 7 comments · Fixed by #10056 or #10934
Assignees
Labels
component:cli Affects the Argo CD CLI enhancement New feature or request good first issue Good for newcomers hacktoberfest security Security related

Comments

@jsoref
Copy link
Member

jsoref commented Jul 19, 2022

Summary

If bcrypt is an important component of how argocd works, and argo-cd (the project) doesn't believe everyone has easy access to bcrypt (I'm willing to believe this, although at this point, it might be possible to argue that everyone has python or even access to docker), then argocd (the program) should offer bcrypt as a command that can be run to do whatever is needed to perform a bcrypt.

Motivation

https://argo-cd.readthedocs.io/en/stable/faq/#i-forgot-the-admin-password-how-do-i-reset-it

To change the password, edit the argocd-secret secret and update the admin.password field with a new bcrypt hash. You can use a site like https://www.browserling.com/tools/bcrypt to generate a new hash.

One should never suggest a website for something relating to credentials. It's always the wrong answer.

Proposal

Add a argocd bcrypt that supports performing whatever action this series of steps imagines a user needs to do.


Disclaimer: At this point, I am not remotely certain these steps are meaningful as they certainly don't correspond to the structure of my instances.

@jsoref jsoref added the enhancement New feature or request label Jul 19, 2022
@crenshaw-dev crenshaw-dev added the security Security related label Jul 20, 2022
@crenshaw-dev
Copy link
Collaborator

At the very least, we should change the docs to recommend a binary install of bcrypt rather than a website.

crenshaw-dev added a commit to crenshaw-dev/argo-cd that referenced this issue Jul 20, 2022
Signed-off-by: CI <michael@crenshaw.dev>
jannfis pushed a commit that referenced this issue Aug 4, 2022
* docs: recommend offline bcrypt (#10050)

Signed-off-by: CI <michael@crenshaw.dev>

* add bcrypt example

Signed-off-by: CI <michael@crenshaw.dev>

* note title

Signed-off-by: CI <michael@crenshaw.dev>
@jsoref
Copy link
Member Author

jsoref commented Aug 4, 2022

@jannfis: Do you want to reopen this to cover #10056 (review)

@crenshaw-dev
Copy link
Collaborator

Yep, my bad, that PR didn't cover everything asked here.

@crenshaw-dev crenshaw-dev reopened this Aug 4, 2022
@jannfis
Copy link
Member

jannfis commented Aug 4, 2022

Yes, I actually merged the linked PR without looking at this issue.

I'm totally in favor of this enhancement proposal. Thanks.

@jannfis
Copy link
Member

jannfis commented Aug 4, 2022

I'm not necessarily fond of exposing it as a first class top level command.

I think the right place where it should live is at argocd admin account - WDYT?

@jsoref
Copy link
Member Author

jsoref commented Aug 4, 2022

If that's the only place that needs it, that sounds good.

(I wasn't trying to ask for a first class command, just a thing to cover whatever argocd needs users to use bcrypt to do)

ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this issue Aug 11, 2022
* docs: recommend offline bcrypt (argoproj#10050)

Signed-off-by: CI <michael@crenshaw.dev>

* add bcrypt example

Signed-off-by: CI <michael@crenshaw.dev>

* note title

Signed-off-by: CI <michael@crenshaw.dev>
@crenshaw-dev crenshaw-dev added good first issue Good for newcomers component:cli Affects the Argo CD CLI GraceHopperOSD2022 Good for 2022 Grace Hopper Celebration Open Source Day labels Sep 14, 2022
@crenshaw-dev crenshaw-dev added hacktoberfest and removed GraceHopperOSD2022 Good for 2022 Grace Hopper Celebration Open Source Day labels Oct 4, 2022
@ameytotawar
Copy link
Contributor

I am working on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:cli Affects the Argo CD CLI enhancement New feature or request good first issue Good for newcomers hacktoberfest security Security related
Projects
None yet
4 participants