Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui add tooltips on repository url links and names (#9868) #10108

Merged
merged 2 commits into from Sep 27, 2022
Merged

fix: ui add tooltips on repository url links and names (#9868) #10108

merged 2 commits into from Sep 27, 2022

Conversation

xieyanke
Copy link
Contributor

@xieyanke xieyanke commented Jul 27, 2022

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #10108 (388b274) into master (a60dd36) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10108   +/-   ##
=======================================
  Coverage   45.76%   45.76%           
=======================================
  Files         234      234           
  Lines       28460    28460           
=======================================
  Hits        13025    13025           
  Misses      13658    13658           
  Partials     1777     1777           
Impacted Files Coverage Δ
util/settings/settings.go 51.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashutosh16
Copy link
Contributor

@xieyanke Thanks for raising the PR. Can you add a screenshot of the change - expected/actual?

@xieyanke
Copy link
Contributor Author

Hi @ashutosh16 , As follows:

image

image

@saumeya saumeya requested a review from keithchong July 28, 2022 06:51
@keithchong
Copy link
Contributor

Hi @xieyanke , I think we need the repo URL as a link so users can click on it to easily navigate to the repo.

Also, if you hover over the link, the full URL does show up at the bottom left corner of the browser anyway (at least from what I've tried using Chrome and Firefox). So I don't think we should remove the usability of the link for the tooltip.

@xieyanke
Copy link
Contributor Author

xieyanke commented Aug 5, 2022

Hi @keithchong, I have solved this problem, now users can hover over the link and the tooltip will show up at the top of it, users also can click on the link to navigate to the repo (I've tested it using Chrome version: 104.0.5112.79 & Firefox version: 103.0)

I think getting the full URL with tooltips is necessary, because when users add a new long url repo and ArgoCD has too many long url repos in repo-list, he cannot determine which one is he added

image

image

@xieyanke xieyanke changed the title fix: ui add tooltips on repository urls and names (#9868) fix: ui add tooltips on repository url links and names (#9868) Aug 5, 2022
Signed-off-by: XieYanke <xieyanke007@gmail.com>
Signed-off-by: XieYanke <xieyanke007@gmail.com>
Copy link
Contributor

@keithchong keithchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keithchong keithchong merged commit f3f7334 into argoproj:master Sep 27, 2022
vgelot pushed a commit to vgelot/argo-cd that referenced this pull request Sep 28, 2022
argoproj#10108)

* fix: ui add tooltips on repository url links and names (argoproj#9868)

Signed-off-by: XieYanke <xieyanke007@gmail.com>

* fix: yarn lint failure

Signed-off-by: XieYanke <xieyanke007@gmail.com>

Signed-off-by: XieYanke <xieyanke007@gmail.com>
Signed-off-by: Vincent <vincent.gelot@akeneo.com>
crenshaw-dev pushed a commit that referenced this pull request Oct 3, 2022
…etAccessControl (#10727)

* fix: ui add tooltips on repository url links and names (#9868) (#10108)

* fix: ui add tooltips on repository url links and names (#9868)

Signed-off-by: XieYanke <xieyanke007@gmail.com>

* fix: yarn lint failure

Signed-off-by: XieYanke <xieyanke007@gmail.com>

Signed-off-by: XieYanke <xieyanke007@gmail.com>
Signed-off-by: Vincent <vincent.gelot@akeneo.com>

* Add feature for storage.cnrm.cloud.google.com/StorageBucketAccessControl

Signed-off-by: Vincent <vincent.gelot@akeneo.com>

Signed-off-by: XieYanke <xieyanke007@gmail.com>
Signed-off-by: Vincent <vincent.gelot@akeneo.com>
Co-authored-by: 谢烟客 <xieyanke007@gmail.com>
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
argoproj#10108)

* fix: ui add tooltips on repository url links and names (argoproj#9868)

Signed-off-by: XieYanke <xieyanke007@gmail.com>

* fix: yarn lint failure

Signed-off-by: XieYanke <xieyanke007@gmail.com>

Signed-off-by: XieYanke <xieyanke007@gmail.com>
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
…etAccessControl (argoproj#10727)

* fix: ui add tooltips on repository url links and names (argoproj#9868) (argoproj#10108)

* fix: ui add tooltips on repository url links and names (argoproj#9868)

Signed-off-by: XieYanke <xieyanke007@gmail.com>

* fix: yarn lint failure

Signed-off-by: XieYanke <xieyanke007@gmail.com>

Signed-off-by: XieYanke <xieyanke007@gmail.com>
Signed-off-by: Vincent <vincent.gelot@akeneo.com>

* Add feature for storage.cnrm.cloud.google.com/StorageBucketAccessControl

Signed-off-by: Vincent <vincent.gelot@akeneo.com>

Signed-off-by: XieYanke <xieyanke007@gmail.com>
Signed-off-by: Vincent <vincent.gelot@akeneo.com>
Co-authored-by: 谢烟客 <xieyanke007@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants