New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ui add tooltips on repository url links and names (#9868) #10108
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10108 +/- ##
=======================================
Coverage 45.76% 45.76%
=======================================
Files 234 234
Lines 28460 28460
=======================================
Hits 13025 13025
Misses 13658 13658
Partials 1777 1777
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@xieyanke Thanks for raising the PR. Can you add a screenshot of the change - expected/actual? |
Hi @ashutosh16 , As follows: |
Hi @xieyanke , I think we need the repo URL as a link so users can click on it to easily navigate to the repo. Also, if you hover over the link, the full URL does show up at the bottom left corner of the browser anyway (at least from what I've tried using Chrome and Firefox). So I don't think we should remove the usability of the link for the tooltip. |
Hi @keithchong, I have solved this problem, now users can hover over the link and the tooltip will show up at the top of it, users also can click on the link to navigate to the repo (I've tested it using Chrome version: 104.0.5112.79 & Firefox version: 103.0) I think getting the full URL with tooltips is necessary, because when users add a new long url repo and ArgoCD has too many long url repos in repo-list, he cannot determine which one is he added |
Signed-off-by: XieYanke <xieyanke007@gmail.com>
Signed-off-by: XieYanke <xieyanke007@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
argoproj#10108) * fix: ui add tooltips on repository url links and names (argoproj#9868) Signed-off-by: XieYanke <xieyanke007@gmail.com> * fix: yarn lint failure Signed-off-by: XieYanke <xieyanke007@gmail.com> Signed-off-by: XieYanke <xieyanke007@gmail.com> Signed-off-by: Vincent <vincent.gelot@akeneo.com>
…etAccessControl (#10727) * fix: ui add tooltips on repository url links and names (#9868) (#10108) * fix: ui add tooltips on repository url links and names (#9868) Signed-off-by: XieYanke <xieyanke007@gmail.com> * fix: yarn lint failure Signed-off-by: XieYanke <xieyanke007@gmail.com> Signed-off-by: XieYanke <xieyanke007@gmail.com> Signed-off-by: Vincent <vincent.gelot@akeneo.com> * Add feature for storage.cnrm.cloud.google.com/StorageBucketAccessControl Signed-off-by: Vincent <vincent.gelot@akeneo.com> Signed-off-by: XieYanke <xieyanke007@gmail.com> Signed-off-by: Vincent <vincent.gelot@akeneo.com> Co-authored-by: 谢烟客 <xieyanke007@gmail.com>
argoproj#10108) * fix: ui add tooltips on repository url links and names (argoproj#9868) Signed-off-by: XieYanke <xieyanke007@gmail.com> * fix: yarn lint failure Signed-off-by: XieYanke <xieyanke007@gmail.com> Signed-off-by: XieYanke <xieyanke007@gmail.com>
…etAccessControl (argoproj#10727) * fix: ui add tooltips on repository url links and names (argoproj#9868) (argoproj#10108) * fix: ui add tooltips on repository url links and names (argoproj#9868) Signed-off-by: XieYanke <xieyanke007@gmail.com> * fix: yarn lint failure Signed-off-by: XieYanke <xieyanke007@gmail.com> Signed-off-by: XieYanke <xieyanke007@gmail.com> Signed-off-by: Vincent <vincent.gelot@akeneo.com> * Add feature for storage.cnrm.cloud.google.com/StorageBucketAccessControl Signed-off-by: Vincent <vincent.gelot@akeneo.com> Signed-off-by: XieYanke <xieyanke007@gmail.com> Signed-off-by: Vincent <vincent.gelot@akeneo.com> Co-authored-by: 谢烟客 <xieyanke007@gmail.com>
Checklist: