Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: display repository's name and URL through the Tooltip component in the repository list #9868

Open
xieyanke opened this issue Jul 4, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@xieyanke
Copy link
Contributor

xieyanke commented Jul 4, 2022

Summary

  1. Display repo's name through the Tooltip component
  2. Display repo's URL through the Tooltip component

Motivation

If the repo's name or URL is too long, we can't get the full information in the repos list

Proposal

<!-- https://github.com/argoproj/argo-cd/blob/master/ui/src/app/settings/components/repos-list/repos-list.tsx -->

<div className='columns small-2'>
    <Tooltip content={repo.name}>
        <span>{repo.name}</span>
    </Tooltip>
</div>
<div className='columns small-5'>
    <Tooltip content={repo.repo}>
        <span>{repo.repo}</span>
    </Tooltip>
</div>                  
@xieyanke xieyanke added the enhancement New feature or request label Jul 4, 2022
@saumeya
Copy link
Contributor

saumeya commented Jul 7, 2022

Hi @xieyanke , Thanks for the issue, do you want to submit a PR with attached screenshots?

@xieyanke
Copy link
Contributor Author

xieyanke commented Jul 18, 2022

@saumeya All right, like this:

image

keithchong pushed a commit that referenced this issue Sep 27, 2022
* fix: ui add tooltips on repository url links and names (#9868)

Signed-off-by: XieYanke <xieyanke007@gmail.com>

* fix: yarn lint failure

Signed-off-by: XieYanke <xieyanke007@gmail.com>

Signed-off-by: XieYanke <xieyanke007@gmail.com>
vgelot pushed a commit to vgelot/argo-cd that referenced this issue Sep 28, 2022
argoproj#10108)

* fix: ui add tooltips on repository url links and names (argoproj#9868)

Signed-off-by: XieYanke <xieyanke007@gmail.com>

* fix: yarn lint failure

Signed-off-by: XieYanke <xieyanke007@gmail.com>

Signed-off-by: XieYanke <xieyanke007@gmail.com>
Signed-off-by: Vincent <vincent.gelot@akeneo.com>
crenshaw-dev pushed a commit that referenced this issue Oct 3, 2022
…etAccessControl (#10727)

* fix: ui add tooltips on repository url links and names (#9868) (#10108)

* fix: ui add tooltips on repository url links and names (#9868)

Signed-off-by: XieYanke <xieyanke007@gmail.com>

* fix: yarn lint failure

Signed-off-by: XieYanke <xieyanke007@gmail.com>

Signed-off-by: XieYanke <xieyanke007@gmail.com>
Signed-off-by: Vincent <vincent.gelot@akeneo.com>

* Add feature for storage.cnrm.cloud.google.com/StorageBucketAccessControl

Signed-off-by: Vincent <vincent.gelot@akeneo.com>

Signed-off-by: XieYanke <xieyanke007@gmail.com>
Signed-off-by: Vincent <vincent.gelot@akeneo.com>
Co-authored-by: 谢烟客 <xieyanke007@gmail.com>
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this issue Oct 7, 2022
argoproj#10108)

* fix: ui add tooltips on repository url links and names (argoproj#9868)

Signed-off-by: XieYanke <xieyanke007@gmail.com>

* fix: yarn lint failure

Signed-off-by: XieYanke <xieyanke007@gmail.com>

Signed-off-by: XieYanke <xieyanke007@gmail.com>
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this issue Oct 7, 2022
…etAccessControl (argoproj#10727)

* fix: ui add tooltips on repository url links and names (argoproj#9868) (argoproj#10108)

* fix: ui add tooltips on repository url links and names (argoproj#9868)

Signed-off-by: XieYanke <xieyanke007@gmail.com>

* fix: yarn lint failure

Signed-off-by: XieYanke <xieyanke007@gmail.com>

Signed-off-by: XieYanke <xieyanke007@gmail.com>
Signed-off-by: Vincent <vincent.gelot@akeneo.com>

* Add feature for storage.cnrm.cloud.google.com/StorageBucketAccessControl

Signed-off-by: Vincent <vincent.gelot@akeneo.com>

Signed-off-by: XieYanke <xieyanke007@gmail.com>
Signed-off-by: Vincent <vincent.gelot@akeneo.com>
Co-authored-by: 谢烟客 <xieyanke007@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants