Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the Argo CD User ID in the Dockerfile #10113

Closed
rumstead opened this issue Jul 27, 2022 · 0 comments · Fixed by #10115
Closed

Expose the Argo CD User ID in the Dockerfile #10113

rumstead opened this issue Jul 27, 2022 · 0 comments · Fixed by #10115
Labels
enhancement New feature or request

Comments

@rumstead
Copy link
Contributor

rumstead commented Jul 27, 2022

Summary

Set the Argo CD user ID as an Arg

Motivation

Clients that need to amend the argocd image sometimes need to change users to install things. Ie,

  1. Adding a custom CA
  2. Adding a different version of templating tools (outside of the plugin framework)

It would be nice to not have to hardcode the 999.

Proposal

Make the ID an ENV in the Dockerfile just like the USER

ARG KUSTOMIZE_VERSION=v4.5.2
ARG ARGOCD_VERSION=v2.3.4
FROM us.gcr.io/k8s-artifacts-prod/kustomize/kustomize:$KUSTOMIZE_VERSION as kustomize

FROM busybox as cacerts
# Grab certs
....

FROM quay.io/argoproj/argocd:$ARGOCD_VERSION
# Grab the version of kustomize we want
COPY --from=kustomize /app/kustomize /usr/local/bin
RUN kustomize version
# Become the root user for installing the certs
USER root
COPY --from=cacerts /tmp/corpcert.cer /usr/local/share/ca-certificates/internal-ca-bundle.crt
RUN update-ca-certificates
# Fallback to the argo user
USER 999 # <-- $ARGO_USER_ID
@rumstead rumstead added the enhancement New feature or request label Jul 27, 2022
rumstead pushed a commit to rumstead/argo-cd that referenced this issue Jul 27, 2022
Signed-off-by: Ryan Umstead <ryan.umstead@blackrock.com>
Signed-off-by: rumstead <rjumstead@gmail.com>
crenshaw-dev pushed a commit that referenced this issue Aug 5, 2022
…#10115)

Signed-off-by: Ryan Umstead <ryan.umstead@blackrock.com>
Signed-off-by: rumstead <rjumstead@gmail.com>

Co-authored-by: Ryan Umstead <ryan.umstead@blackrock.com>
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this issue Aug 11, 2022
…j#10113) (argoproj#10115)

Signed-off-by: Ryan Umstead <ryan.umstead@blackrock.com>
Signed-off-by: rumstead <rjumstead@gmail.com>

Co-authored-by: Ryan Umstead <ryan.umstead@blackrock.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant