Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to subscribe to notification from Application Details page #10310

Closed
1 of 2 tasks
alexmt opened this issue Aug 12, 2022 · 3 comments · Fixed by #10839
Closed
1 of 2 tasks

Ability to subscribe to notification from Application Details page #10310

alexmt opened this issue Aug 12, 2022 · 3 comments · Fixed by #10839
Assignees
@aborilov @Marvin9
Labels
component:notifications Related to notifications subsystem enhancement New feature or request type:usability Enhancement of an existing feature

Comments

@alexmt
Copy link
Collaborator

alexmt commented Aug 12, 2022 •
edited

Summary

It should be possible to subscribe to a notification from the Application Details. The user should be able to open the Application Details page and add required subscriptions using input with auto-completion.

Motivation

It is already possible to subscribe to notifications by modifying annotations hoverer this is a pretty poor user experience. User have to understand annotation structure and have to guess which services and triggers are available.

Proposal

Two changes are required:

  • Implement notifications API that would expose list of configured triggers and services
  • Implement UI that leverages notifications API and helps user to create correct annotation.
@alexmt alexmt added enhancement New feature or request type:usability Enhancement of an existing feature component:notifications Related to notifications subsystem labels Aug 12, 2022
@alexmt alexmt mentioned this issue Aug 12, 2022
Merged
10 tasks
@aborilov
Copy link
Contributor

working on it

@alexmt
Copy link
Collaborator Author

alexmt commented Oct 4, 2022

API is done. Thanks @aborilov

@Marvin9
Copy link
Contributor

Marvin9 commented Oct 4, 2022

Can you please assign me?

@Marvin9 Marvin9 mentioned this issue Oct 7, 2022
Merged
10 tasks
alexmt pushed a commit that referenced this issue Oct 12, 2022
@Marvin9
feat(ui): notification subscriptions edit field #10310 (#10839)
05dce81 
* feat(ui): notification subscriptions edit field

> this new field is just an abstraction of relevant annotations

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

* fix: codeql regex issue

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
alexmt pushed a commit that referenced this issue Oct 14, 2022
@Marvin9 @alexmt
feat(ui): notification subscriptions edit field #10310 (#10839)
39f9565 
* feat(ui): notification subscriptions edit field

> this new field is just an abstraction of relevant annotations

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

* fix: codeql regex issue

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
nbjohnson pushed a commit to nbjohnson/argo-cd that referenced this issue Oct 18, 2022
@Marvin9 @nbjohnson
feat(ui): notification subscriptions edit field argoproj#10310 (argop…
7fb5cd4 
…roj#10839)

* feat(ui): notification subscriptions edit field

> this new field is just an abstraction of relevant annotations

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

* fix: codeql regex issue

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: Nicholas Johnson <nbjohnson10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborilov aborilov

@Marvin9 Marvin9

Labels
component:notifications Related to notifications subsystem enhancement New feature or request type:usability Enhancement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ui): notification subscriptions edit field #10310 Marvin9/argo-cd
3 participants
@alexmt @aborilov @Marvin9