New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix indentation of example AppProject in 'Sync Windows' documentation #10388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crenshaw-dev
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks @waltforme!
Codecov Report
@@ Coverage Diff @@
## master #10388 +/- ##
=======================================
Coverage 45.92% 45.92%
=======================================
Files 229 229
Lines 28278 28278
=======================================
Hits 12987 12987
Misses 13518 13518
Partials 1773 1773
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ciiay
pushed a commit
to ciiay/argo-cd
that referenced
this pull request
Aug 18, 2022
…tation (argoproj#10388) Signed-off-by: Yi Cai <yicai@redhat.com>
crenshaw-dev
added a commit
that referenced
this pull request
Aug 19, 2022
* fix: missing actions (#10327) (#10359) Signed-off-by: CI <michael@crenshaw.dev> Signed-off-by: CI <michael@crenshaw.dev> Signed-off-by: Yi Cai <yicai@redhat.com> * chore: infer managed resources health from redis instead of storing it in CRD (#10191) * chore: infer managed resources health from redis instead of storing it in CRD Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * apply reviewer notes Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Yi Cai <yicai@redhat.com> * fix: Add logic to handle for fileHandle.Close() (#9963) (#10361) Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: Yi Cai <yicai@redhat.com> * docs: fix typo in upgrade notes (#10377) Signed-off-by: Xijun Dai <daixijun1990@gmail.com> Signed-off-by: Xijun Dai <daixijun1990@gmail.com> Signed-off-by: Yi Cai <yicai@redhat.com> * fix: add space before prompt in CLI (#10362) Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: Yi Cai <yicai@redhat.com> * docs: fix indentation of example AppProject in 'Sync Windows' documentation (#10388) Signed-off-by: Yi Cai <yicai@redhat.com> * fix: Correctly assume cluster-scoped resources to be self-referenced (#10390) Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: Yi Cai <yicai@redhat.com> * ui-make-https-repo-credential-editable Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> * Minor format fix Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> * Minor fix for unclickable input field Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> * Updates for comments Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> * ui-make-https-repo-credential-editable Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> * Minor format fix Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> * Minor fix for unclickable input field Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> * Updates for comments Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: CI <michael@crenshaw.dev> Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: Xijun Dai <daixijun1990@gmail.com> Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: ciiay <yicai@redhat.com> Co-authored-by: Michael Crenshaw <michael@crenshaw.dev> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: my-git9 <xin.li@daocloud.io> Co-authored-by: Xijun Dai <daixijun1990@gmail.com> Co-authored-by: Jun Duan <jun.duan@ibm.com> Co-authored-by: jannfis <jann@mistrust.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix while I was reading the docs.