Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Repos and other setting items editable in the Argo CD UI #9108

Closed
ciiay opened this issue Apr 14, 2022 · 3 comments · Fixed by #9782
Closed

Make Repos and other setting items editable in the Argo CD UI #9108

ciiay opened this issue Apr 14, 2022 · 3 comments · Fixed by #9782
Assignees
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request

Comments

@ciiay
Copy link
Contributor

ciiay commented Apr 14, 2022

Summary

We got feedback from an Argo CD user that it would be nice to have as many as the settings to be editable.

Motivation

Currently it's possible to add/delete things in the repo list, but not update.

Clusters and Projects are editable in UI now, I would like to be able to update repos and other settings using the Argo CD UI

(https://cd.apps.argoproj.io/settings/repos)

Proposal

Create a repo details page which allows updating selected repo information.

@ciiay ciiay added the enhancement New feature or request label Apr 14, 2022
@ciiay
Copy link
Contributor Author

ciiay commented Apr 14, 2022

According to the discussion from April 14th Argo Contributor Experience Meeting, some of the settings are designed to be immutable, such as certificates and keys.

For repositories, I confirmed with @rbreeze that there's already a CLI command argocd repo add --upsert to do so, so it should be an easy UI change to make repositories editable.

For account settings, we can open a discussion about what kind of information needs to be editable and worth the change.

@saumeya saumeya added the component:ui User interfaces bugs and enhancements label Apr 21, 2022
@Morriz
Copy link

Morriz commented Apr 26, 2022

Can this be prioritized? UX wise it is really unfriendly to:

  • not validate user input up front
  • then serve short lived error bubbles from the api
  • navigating away from the form input screen, erasing user input
  • and then also NOT allowing to edit the resource

So to start, you could also not navigate away on error, allowing us to keep trial/erroring on your black box UI in the hope to get things right ;p

@Morriz
Copy link

Morriz commented Apr 26, 2022

Btw, I added a separate UX issue for those concerns: #9217

crenshaw-dev added a commit that referenced this issue Aug 19, 2022
* fix: missing actions (#10327) (#10359)

Signed-off-by: CI <michael@crenshaw.dev>

Signed-off-by: CI <michael@crenshaw.dev>
Signed-off-by: Yi Cai <yicai@redhat.com>

* chore: infer managed resources health from redis instead of storing it in CRD (#10191)

* chore: infer managed resources health from redis instead of storing it in CRD

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* apply reviewer notes

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Yi Cai <yicai@redhat.com>

* fix: Add logic to handle for fileHandle.Close() (#9963) (#10361)

Signed-off-by: xin.li <xin.li@daocloud.io>

Signed-off-by: xin.li <xin.li@daocloud.io>
Signed-off-by: Yi Cai <yicai@redhat.com>

* docs: fix typo in upgrade notes (#10377)

Signed-off-by: Xijun Dai <daixijun1990@gmail.com>

Signed-off-by: Xijun Dai <daixijun1990@gmail.com>
Signed-off-by: Yi Cai <yicai@redhat.com>

* fix: add space before prompt in CLI (#10362)

Signed-off-by: xin.li <xin.li@daocloud.io>

Signed-off-by: xin.li <xin.li@daocloud.io>
Signed-off-by: Yi Cai <yicai@redhat.com>

* docs: fix indentation of example AppProject in 'Sync Windows' documentation (#10388)

Signed-off-by: Yi Cai <yicai@redhat.com>

* fix: Correctly assume cluster-scoped resources to be self-referenced (#10390)

Signed-off-by: jannfis <jann@mistrust.net>

Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: Yi Cai <yicai@redhat.com>

* ui-make-https-repo-credential-editable

Signed-off-by: ciiay <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>

* Minor format fix

Signed-off-by: ciiay <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>

* Minor fix for unclickable input field

Signed-off-by: ciiay <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>

* Updates for comments

Signed-off-by: ciiay <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>

* ui-make-https-repo-credential-editable

Signed-off-by: ciiay <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>

* Minor format fix

Signed-off-by: ciiay <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>

* Minor fix for unclickable input field

Signed-off-by: ciiay <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>

* Updates for comments

Signed-off-by: ciiay <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>

Signed-off-by: CI <michael@crenshaw.dev>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: xin.li <xin.li@daocloud.io>
Signed-off-by: Xijun Dai <daixijun1990@gmail.com>
Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: ciiay <yicai@redhat.com>
Co-authored-by: Michael Crenshaw <michael@crenshaw.dev>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: my-git9 <xin.li@daocloud.io>
Co-authored-by: Xijun Dai <daixijun1990@gmail.com>
Co-authored-by: Jun Duan <jun.duan@ibm.com>
Co-authored-by: jannfis <jann@mistrust.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants