fix: Remove quotes from delete dialog #10008

[JessieTeng89]

fix: Remove quotes from delete dialog #10008
Fixes #10008

[codecov]

Codecov Report

Merging #10471 (57ff13f) into master (6717162) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10471   +/-   ##
=======================================
  Coverage   45.76%   45.76%           
=======================================
  Files         234      234           
  Lines       28460    28460           
=======================================
  Hits        13025    13025           
  Misses      13658    13658           
  Partials     1777     1777           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ashutosh16]

The HTML tag should not be displayed in the dialog box, not sure if this is intentional

[jsoref]

Could you provide a picture of the dialog?

[JessieTeng89]

Could you provide a picture of the dialog?

Please find the screenshots for the current changes:

[JessieTeng89]

@rbreeze Can I request your approval? So that we can merge it, or I appreciate with your any comments

[rbreeze]

<kbd> is intended for keyboard input, could we use <pre> instead?

[jsoref]

@rbreeze: this is keyboard input, we're asking users to literally type that content!

[JessieTeng89]

<kbd> is intended for keyboard input, could we use <pre> instead?

I tried to use <pre> instead, we need to add a css style like display: inline-block as this tag is a block-level element.

And you can see the change and the style in following screenshot, if it is OK for you, I can do the change

[rbreeze]

let’s stick with kbd

[JessieTeng89]

let’s stick with kbd

Hi @jsoref @rbreeze Can I know how to merge it, it seems I cannot do that even its status is ready

[jsoref]

Someone with the ability to merge will manage that (it isn't me and it isn't you).