New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove quotes from delete dialog #10008
Comments
Can I pick this up? |
@crenshaw-dev I can work on this if this is still available |
@deepto98: sure. |
Hi, @deepto98 did you solve this issue and if you did then can you please how did you do that I know to this so it will be very helpful to understand how to work on this type of issue. |
…oj#10008) Signed-off-by: CI <michael@crenshaw.dev>
Here's an attempt: #10305 I haven't tested it yet. |
Can I work on this issue and assign to me if it is still needed? |
Disabling text selection is a no-no in my book. That's just torture. Lots of sites try to do such things and it's a really bad anti-pattern. I'm reasonably happy w/ the theoretical changes @crenshaw-dev made, although I'd like to know if they work... |
@jsoref I agree, I saw the pull request created by @crenshaw-dev has been closed, so I tried to find a solution for this issue. |
@jsoref Are you good with the message style change like following screenshot? I removed the unused quotes and display the resource/application name with bold, or do you have any other ideas? |
If we could have the equivalent of |
@jsoref By researching, it seems |
Ah, I didn't necessarily mean the literal html That said, |
Signed-off-by: Teng, Jessie <yilin.teng@fmr.com>
Summary
Quotation marks should be used to delineate things and make it clear that things are not prose.
There are other ways to delineate such things, e.g.
<tt>text</tt>
instead of'text'
.Motivation
I've watched people try to select the name of the resource in order to delete an object, e.g.:
They generally trip on the
'
s (there are magical ways to use a mouse to avoid grabbing them, but, forcing users to deal w/ this isn't very nice).Proposal
'%s'
to<tt>%s</tt>
(or the equivalent of<tt>
...)The text was updated successfully, but these errors were encountered: