Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes from delete dialog #10008

Closed
jsoref opened this issue Jul 15, 2022 · 14 comments · Fixed by #10471
Closed

Remove quotes from delete dialog #10008

jsoref opened this issue Jul 15, 2022 · 14 comments · Fixed by #10471
Assignees
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request good first issue Good for newcomers GraceHopperOSD2022 Good for 2022 Grace Hopper Celebration Open Source Day type:usability Enhancement of an existing feature

Comments

@jsoref
Copy link
Member

jsoref commented Jul 15, 2022

Summary

Quotation marks should be used to delineate things and make it clear that things are not prose.

There are other ways to delineate such things, e.g. <tt>text</tt> instead of 'text'.

Motivation

I've watched people try to select the name of the resource in order to delete an object, e.g.:
image

They generally trip on the 's (there are magical ways to use a mouse to avoid grabbing them, but, forcing users to deal w/ this isn't very nice).

Proposal

  1. Switch from '%s' to <tt>%s</tt> (or the equivalent of <tt>...)
  2. Don't include the name of the resource in the delete line, watching people try to copy the name from the field and having it run away is watching them be tortured...
@jsoref jsoref added the enhancement New feature or request label Jul 15, 2022
@crenshaw-dev crenshaw-dev added good first issue Good for newcomers type:usability Enhancement of an existing feature component:ui User interfaces bugs and enhancements GraceHopperOSD2022 Good for 2022 Grace Hopper Celebration Open Source Day labels Jul 15, 2022
@deepto98
Copy link

Can I pick this up?

@JessieTeng89
Copy link
Contributor

@crenshaw-dev I can work on this if this is still available

@jsoref
Copy link
Member Author

jsoref commented Jul 19, 2022

@deepto98: sure.

@souravsk
Copy link

Hi, @deepto98 did you solve this issue and if you did then can you please how did you do that I know to this so it will be very helpful to understand how to work on this type of issue.

@crenshaw-dev
Copy link
Collaborator

Here's an attempt: #10305

I haven't tested it yet.

@JessieTeng89
Copy link
Contributor

Can I work on this issue and assign to me if it is still needed?
@crenshaw-dev @jsoref

@JessieTeng89
Copy link
Contributor

Following is the plan, I will firstly use some HTML elements to instead of quotation marks for the resource name, and then I will disable the text selection for the resource name so that we can force user to input the resource name by manually without copy/paste.
image

@jsoref
Copy link
Member Author

jsoref commented Aug 23, 2022

Disabling text selection is a no-no in my book. That's just torture. Lots of sites try to do such things and it's a really bad anti-pattern.

I'm reasonably happy w/ the theoretical changes @crenshaw-dev made, although I'd like to know if they work...

@JessieTeng89
Copy link
Contributor

@jsoref I agree, I saw the pull request created by @crenshaw-dev has been closed, so I tried to find a solution for this issue.
Maybe we can update the message and replace the quotes first.

@JessieTeng89
Copy link
Contributor

@jsoref Are you good with the message style change like following screenshot? I removed the unused quotes and display the resource/application name with bold, or do you have any other ideas?
Screen Shot 2022-08-25 at 13 28 02

@jsoref
Copy link
Member Author

jsoref commented Aug 25, 2022

If we could have the equivalent of <tt> (monospace font) instead of bold, I'd prefer it. But, what you have is better than the current.

@JessieTeng89
Copy link
Contributor

JessieTeng89 commented Aug 26, 2022

@jsoref By researching, it seems <tt> is already deprecated in HTML5, please see this blog https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt.
Instead it recommends us to use the more semantically helpful <code>, <kbd>, <samp>, or <var> elements for inline text that needs to be presented in monospace type
I tried all in my local environment, please check if any style you preferrer to use.
<code>
image

<kbd>
image

<samp>
image

<var>
image

@jsoref
Copy link
Member Author

jsoref commented Aug 26, 2022

Ah, I didn't necessarily mean the literal html <tt>, just a conceptual monospace w/o me writing a css style.

That said, <kbd> appears to both be semantically correct and have a reasonable rendering.

JessieTeng89 added a commit to fidelity-contributions/argoproj-argo-cd that referenced this issue Aug 29, 2022
Signed-off-by: Teng, Jessie <yilin.teng@fmr.com>
@JessieTeng89
Copy link
Contributor

JessieTeng89 commented Aug 30, 2022

@jsoref
Created a PR for this issue, please help to check if it is good for merging.
#10471

rbreeze pushed a commit that referenced this issue Sep 1, 2022
Signed-off-by: Teng, Jessie <yilin.teng@fmr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request good first issue Good for newcomers GraceHopperOSD2022 Good for 2022 Grace Hopper Celebration Open Source Day type:usability Enhancement of an existing feature
Projects
None yet
5 participants