New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In Application Details, link the path
field directly to the path in the repo
#10568
Comments
@crenshaw-dev , I would like to work on this issue, But can you please help me which file needs to be fixed. |
@surbhiahuja probably this file. |
@crenshaw-dev , If this issue isn't already solved, can I also work on this? |
@RutviShukla -- Yes, you can absolutely work on this as well! :) If you need any assistance, please feel free to send a message in the #argo-proj Open Source Day Slack channel. |
Hey I made PR that support this request #10860. Who can take a look ? |
* Wrap error objects to include context Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Revert "Wrap error objects to include context" This reverts commit d1789bd. Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * In Application Details, link the path field directly to the path in the repo Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * fix: duplicate source namespace validation (#10853) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * docs: fix examples for ArgoCD ApplicationSet Git Generator (#10857) * Doc: ArgoCD ApplicationSet Git directory Signed-off-by: toyamagu <toyamagu2021@gmail.com> * Docs: use "my-project" rather than default project Signed-off-by: toyamagu <toyamagu2021@gmail.com> Signed-off-by: toyamagu <toyamagu2021@gmail.com> Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Change 'branch' to 'src' Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Fix CR Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Fix CR Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * renaming Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Add comment Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: toyamagu <toyamagu2021@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: toyamagu <83329336+toyamagu-2021@users.noreply.github.com>
…oj#10860) * Wrap error objects to include context Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Revert "Wrap error objects to include context" This reverts commit d1789bd. Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * In Application Details, link the path field directly to the path in the repo Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * fix: duplicate source namespace validation (argoproj#10853) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * docs: fix examples for ArgoCD ApplicationSet Git Generator (argoproj#10857) * Doc: ArgoCD ApplicationSet Git directory Signed-off-by: toyamagu <toyamagu2021@gmail.com> * Docs: use "my-project" rather than default project Signed-off-by: toyamagu <toyamagu2021@gmail.com> Signed-off-by: toyamagu <toyamagu2021@gmail.com> Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Change 'branch' to 'src' Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Fix CR Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Fix CR Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * renaming Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Add comment Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: toyamagu <toyamagu2021@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: toyamagu <83329336+toyamagu-2021@users.noreply.github.com> Signed-off-by: Nicholas Johnson <nbjohnson10@gmail.com>
Summary
The bottom field should be a link.
Motivation
It would be nice to be able to navigate directly to the directory containing the resources which are to be deployed by the app.
Proposal
For GitHub the path should be predictable. I'm not sure about other providers.
The text was updated successfully, but these errors were encountered: