feat(ui): Collapsable sidebar with filters #10626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Codecov ReportBase: 45.68% // Head: 45.68% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #10626 +/- ##
=======================================
Coverage 45.68% 45.68%
=======================================
Files 236 236
Lines 28668 28668
=======================================
Hits 13097 13097
Misses 13779 13779
Partials 1792 1792 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jessesuen
reviewed
Sep 16, 2022
Signed-off-by: Remington Breeze <remington@breeze.software>
|
@jessesuen How does this look?
|
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
ashutosh16
reviewed
Sep 27, 2022
|
|
||
| require('./layout.scss'); | ||
|
|
||
| export interface LayoutProps { |
There was a problem hiding this comment.
Is the layout component the main layout or sidebar layout?
There was a problem hiding this comment.
Layout is a main layout, copied from argo-ui
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Oct 7, 2022
Signed-off-by: Remington Breeze <remington@breeze.software>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: