Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Collapsable sidebar with filters #10626

Merged
merged 21 commits into from
Sep 29, 2022

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Sep 16, 2022

CleanShot 2022-09-16 at 14 09 12@2x
CleanShot 2022-09-16 at 14 09 21@2x

CleanShot 2022-09-16 at 14 09 02@2x
CleanShot 2022-09-16 at 14 09 17@2x

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt September 16, 2022 21:34
Signed-off-by: Remington Breeze <remington@breeze.software>
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.68%. Comparing base (f3f7334) to head (61653f8).
Report is 2549 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10626   +/-   ##
=======================================
  Coverage   45.68%   45.68%           
=======================================
  Files         236      236           
  Lines       28668    28668           
=======================================
  Hits        13097    13097           
  Misses      13779    13779           
  Partials     1792     1792           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there an outline surrounding these filters? Can they be removed?

image

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze
Copy link
Member Author

rbreeze commented Sep 17, 2022

@jessesuen How does this look?

CleanShot 2022-09-16 at 17 14 39@2x

CleanShot 2022-09-16 at 17 14 54@2x

Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>

require('./layout.scss');

export interface LayoutProps {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the layout component the main layout or sidebar layout?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout is a main layout, copied from argo-ui

Signed-off-by: Remington Breeze <remington@breeze.software>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rbreeze rbreeze enabled auto-merge (squash) September 28, 2022 21:56
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze merged commit 856ba52 into argoproj:master Sep 29, 2022
@rbreeze rbreeze deleted the sidebar-collapse branch September 29, 2022 01:14
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
Signed-off-by: Remington Breeze <remington@breeze.software>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants