Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update Generators-Pull-Request.md #10642

Merged
merged 2 commits into from Sep 30, 2022
Merged

docs: Update Generators-Pull-Request.md #10642

merged 2 commits into from Sep 30, 2022

Conversation

mabusaa
Copy link
Contributor

@mabusaa mabusaa commented Sep 20, 2022 •
edited by crenshaw-dev

Closes #10643

Signed-off-by: Mohammad Abusaa abusaa_mz@hotmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@mabusaa
Update Generators-Pull-Request.md
0e40c59 
Signed-off-by: Mohammad Abusaa <abusaa_mz@hotmail.com>
@mabusaa mabusaa mentioned this pull request Sep 20, 2022
Closed
3 tasks
@codecov
Copy link

codecov bot commented Sep 20, 2022 •
edited

Codecov Report

Base: 45.75% // Head: 45.75% // No change to project coverage 👍

Coverage data is based on head (2b0a6b2) compared to base (02bf903).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #10642   +/-   ##
=======================================
  Coverage   45.75%   45.75%           
=======================================
  Files         236      236           
  Lines       28527    28527           
=======================================
  Hits        13053    13053           
  Misses      13669    13669           
  Partials     1805     1805
Impacted Files Coverage Δ
util/settings/settings.go 51.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mabusaa mabusaa changed the title Update Generators-Pull-Request.md docs: Update Generators-Pull-Request.md Sep 24, 2022
crenshaw-dev
crenshaw-dev approved these changes Sep 30, 2022
View reviewed changes
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks @mabusaa!

@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label Sep 30, 2022
@crenshaw-dev crenshaw-dev merged commit 5ff4dd2 into argoproj:master Sep 30, 2022
crenshaw-dev pushed a commit that referenced this pull request Sep 30, 2022
@mabusaa @crenshaw-dev
docs: Update Generators-Pull-Request.md (#10643) (#10642)
fc8f57a 
Signed-off-by: Mohammad Abusaa <abusaa_mz@hotmail.com>

Signed-off-by: Mohammad Abusaa <abusaa_mz@hotmail.com>
@crenshaw-dev
Copy link
Collaborator

Cherry-picked onto release-2.4 for 2.4.13.

@mabusaa mabusaa mentioned this pull request Oct 1, 2022
Merged
@mabusaa
Copy link
Contributor Author

mabusaa commented Oct 1, 2022

great and thx @crenshaw-dev

ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
@mabusaa @ashutosh16
docs: Update Generators-Pull-Request.md (argoproj#10643) (argoproj#10642
9741b70 
)

Signed-off-by: Mohammad Abusaa <abusaa_mz@hotmail.com>

Signed-off-by: Mohammad Abusaa <abusaa_mz@hotmail.com>
@mabusaa mabusaa deleted the patch-1 branch October 12, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update pull request generator docs for requeueAfterSeconds indentation
2 participants
@mabusaa @crenshaw-dev