Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pull request generator docs for requeueAfterSeconds indentation #10643

Closed
1 of 3 tasks
mabusaa opened this issue Sep 20, 2022 · 1 comment · Fixed by #10642
Closed
1 of 3 tasks

Update pull request generator docs for requeueAfterSeconds indentation #10643

mabusaa opened this issue Sep 20, 2022 · 1 comment · Fixed by #10642
Labels
bug Something isn't working

Comments

@mabusaa
Copy link
Contributor

mabusaa commented Sep 20, 2022 •
edited

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

when you apply the yaml example in this page https://github.com/argoproj/argo-cd/blob/v2.4.12/docs/operator-manual/applicationset/Generators-Pull-Request.md

you will get an error for requeueAfterSeconds as below :

error validating data: ValidationError(ApplicationSet.spec): unknown field "requeueAfterSeconds" in io.argoproj.v1alpha1.ApplicationSet.spec

To Reproduce

Expected behavior

Screenshots

Version

v2.4.11

Logs

Paste any relevant application logs here.
@mabusaa mabusaa added the bug Something isn't working label Sep 20, 2022
@mabusaa mabusaa mentioned this issue Sep 20, 2022
Merged
10 tasks
@mabusaa
Copy link
Contributor Author

mabusaa commented Sep 20, 2022

I have created PR to fix the indentation #10642

crenshaw-dev pushed a commit that referenced this issue Sep 30, 2022
@mabusaa
docs: Update Generators-Pull-Request.md (#10643) (#10642)
5ff4dd2 
Signed-off-by: Mohammad Abusaa <abusaa_mz@hotmail.com>

Signed-off-by: Mohammad Abusaa <abusaa_mz@hotmail.com>
crenshaw-dev pushed a commit that referenced this issue Sep 30, 2022
@mabusaa @crenshaw-dev
docs: Update Generators-Pull-Request.md (#10643) (#10642)
fc8f57a 
Signed-off-by: Mohammad Abusaa <abusaa_mz@hotmail.com>

Signed-off-by: Mohammad Abusaa <abusaa_mz@hotmail.com>
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this issue Oct 7, 2022
@mabusaa @ashutosh16
docs: Update Generators-Pull-Request.md (argoproj#10643) (argoproj#10642
9741b70 
)

Signed-off-by: Mohammad Abusaa <abusaa_mz@hotmail.com>

Signed-off-by: Mohammad Abusaa <abusaa_mz@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Update Generators-Pull-Request.md mabusaa/argo-cd
1 participant
@mabusaa