feat: add health checks for storage.cnrm.cloud.google.com/StorageBucketAccessControl #10727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argoproj#10108) * fix: ui add tooltips on repository url links and names (argoproj#9868) Signed-off-by: XieYanke <xieyanke007@gmail.com> * fix: yarn lint failure Signed-off-by: XieYanke <xieyanke007@gmail.com> Signed-off-by: XieYanke <xieyanke007@gmail.com> Signed-off-by: Vincent <vincent.gelot@akeneo.com>
Signed-off-by: Vincent <vincent.gelot@akeneo.com>
vgelot
force-pushed
the
feat-storage.cnrm.cloud.google.com-StorageBucketAccessControl
branch
from
ab4a326
to
e0ef329
Compare
Codecov ReportBase: 45.65% // Head: 45.65% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #10727 +/- ##
=======================================
Coverage 45.65% 45.65%
=======================================
Files 236 236
Lines 28702 28702
=======================================
Hits 13104 13104
Misses 13804 13804
Partials 1794 1794
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
crenshaw-dev
requested changes
Sep 30, 2022
There was a problem hiding this comment.
@vgelot if you want to split the tooltip part into a new PR, I'll happily merge the health check!
crenshaw-dev
changed the title
…BucketAccessControl
crenshaw-dev
approved these changes
Oct 3, 2022
vgelot
deleted the
feat-storage.cnrm.cloud.google.com-StorageBucketAccessControl
branch
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Oct 7, 2022
…etAccessControl (argoproj#10727) * fix: ui add tooltips on repository url links and names (argoproj#9868) (argoproj#10108) * fix: ui add tooltips on repository url links and names (argoproj#9868) Signed-off-by: XieYanke <xieyanke007@gmail.com> * fix: yarn lint failure Signed-off-by: XieYanke <xieyanke007@gmail.com> Signed-off-by: XieYanke <xieyanke007@gmail.com> Signed-off-by: Vincent <vincent.gelot@akeneo.com> * Add feature for storage.cnrm.cloud.google.com/StorageBucketAccessControl Signed-off-by: Vincent <vincent.gelot@akeneo.com> Signed-off-by: XieYanke <xieyanke007@gmail.com> Signed-off-by: Vincent <vincent.gelot@akeneo.com> Co-authored-by: 谢烟客 <xieyanke007@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature for storage.cnrm.cloud.google.com StorageBucketAccessControl