Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add declarative syntax examples for helm #10764

Conversation

morey-tech
Copy link
Contributor

Closes #10763

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Base: 45.65% // Head: 45.65% // No change to project coverage 👍

Coverage data is based on head (791b53f) compared to base (11c44f2).
Patch has no changes to coverable lines.

❗ Current head 791b53f differs from pull request most recent head ec13cee. Consider uploading reports for the commit ec13cee to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10764   +/-   ##
=======================================
  Coverage   45.65%   45.65%           
=======================================
  Files         236      236           
  Lines       28702    28702           
=======================================
  Hits        13104    13104           
  Misses      13804    13804           
  Partials     1794     1794           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition. Thanks @morey-tech!

@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label Oct 3, 2022
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) October 3, 2022 14:45
@crenshaw-dev crenshaw-dev merged commit 214b980 into argoproj:master Oct 5, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
* docs: add declarative syntax examples for helm

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* fix spacing

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm User Guide missing declarative examples
2 participants