Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add filter icon to help users find filters #10809

Merged
merged 6 commits into from Oct 5, 2022

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Oct 5, 2022

After sidebar update, it may be confusing where the filters went. This PR does 3 things to improve experience:

  1. Sidebar is expanded by default (previously was collapsed by default). This way users who install/upgrade to 2.5 will see the filters the first time they use it and can hide if they choose.
  2. When collapsed, instead of showing an arrow there is now a filter icon with a tooltip
  3. Improves the spacing/margins of FontAwesome icons in the sidebar; previously, custom sidebar items with FontAwesome icons looked strange.

Before:
CleanShot 2022-10-05 at 12 30 30@2x

After:
CleanShot 2022-10-05 at 12 29 41@2x
CleanShot 2022-10-05 at 12 29 50@2x

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@@ -52,8 +52,10 @@
width: 35px;
}

i.fa-sign-in-alt {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.fa-sign-in-alt was an unused style

@rbreeze rbreeze requested a review from alexmt October 5, 2022 19:35
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 45.67% // Head: 45.67% // No change to project coverage 👍

Coverage data is based on head (96a48fb) compared to base (9849a17).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10809   +/-   ##
=======================================
  Coverage   45.67%   45.67%           
=======================================
  Files         236      236           
  Lines       28697    28697           
=======================================
  Hits        13106    13106           
  Misses      13799    13799           
  Partials     1792     1792           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexmt
Copy link
Collaborator

alexmt commented Oct 5, 2022

I feel it is strange that expand button is changing to filter on some pages. Instead can keep expand button and "collapse" filters into filter icon:

image

The filter icon would duplicate expand button however it still makes more sense to me.

@alexmt alexmt merged commit 53a210e into argoproj:master Oct 5, 2022
alexmt pushed a commit that referenced this pull request Oct 5, 2022
* fix: add clear indicator that filters are now in sidebar

Signed-off-by: Remington Breeze <remington@breeze.software>

* address code review

Signed-off-by: Remington Breeze <remington@breeze.software>

Signed-off-by: Remington Breeze <remington@breeze.software>
@alexmt
Copy link
Collaborator

alexmt commented Oct 5, 2022

Cherry-picked into 2.5

ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
* fix: add clear indicator that filters are now in sidebar

Signed-off-by: Remington Breeze <remington@breeze.software>

* address code review

Signed-off-by: Remington Breeze <remington@breeze.software>

Signed-off-by: Remington Breeze <remington@breeze.software>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants