-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add filter icon to help users find filters #10809
Conversation
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@@ -52,8 +52,10 @@ | |||
width: 35px; | |||
} | |||
|
|||
i.fa-sign-in-alt { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i.fa-sign-in-alt
was an unused style
Codecov ReportBase: 45.67% // Head: 45.67% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #10809 +/- ##
=======================================
Coverage 45.67% 45.67%
=======================================
Files 236 236
Lines 28697 28697
=======================================
Hits 13106 13106
Misses 13799 13799
Partials 1792 1792 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Remington Breeze <remington@breeze.software>
… sidebar-filter-icon
* fix: add clear indicator that filters are now in sidebar Signed-off-by: Remington Breeze <remington@breeze.software> * address code review Signed-off-by: Remington Breeze <remington@breeze.software> Signed-off-by: Remington Breeze <remington@breeze.software>
Cherry-picked into 2.5 |
* fix: add clear indicator that filters are now in sidebar Signed-off-by: Remington Breeze <remington@breeze.software> * address code review Signed-off-by: Remington Breeze <remington@breeze.software> Signed-off-by: Remington Breeze <remington@breeze.software>
After sidebar update, it may be confusing where the filters went. This PR does 3 things to improve experience:
Before:
After:
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: