Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admins should have full applicationsets permissions by default #10810

Closed
crenshaw-dev opened this issue Oct 5, 2022 · 1 comment · Fixed by #10891
Closed

Admins should have full applicationsets permissions by default #10810

crenshaw-dev opened this issue Oct 5, 2022 · 1 comment · Fixed by #10891
Assignees
@karengineering
Labels
bug Something isn't working cherry-pick/2.5 good first issue Good for newcomers hacktoberfest
Milestone
v2.5

Comments

@crenshaw-dev
Copy link
Collaborator

Describe the bug

Admin should have full permissions for applicationsets by default. But they do not.

To Reproduce

Logged in as admin

$ kubectl apply -n argocd -f applicationset/examples/list-generator/list-example.yaml
$ argocd appset get guestbook
FATA[0000] rpc error: code = PermissionDenied desc = permission denied: applicationsets, get, default/guestbook, sub: admin, iat: 2022-10-05T19:27:42Z

Expected behavior

The admin user should be able to get the applicationset.

Version

argocd: v2.5.0+f7b0879
...
argocd-server: v2.5.0-rc1+2bf51f4
...

Proposed fix

Update the builtin RBAC policy to give admin get, create, update, and delete on the applicationsets resource.

Thanks to Raymond Wong for pointing out the problem!
@crenshaw-dev crenshaw-dev added bug Something isn't working good first issue Good for newcomers hacktoberfest cherry-pick/2.5 labels Oct 5, 2022
@crenshaw-dev crenshaw-dev added this to the v2.5 milestone Oct 5, 2022
@karengineering
Copy link
Contributor

I would like to work on this issue.

@karengineering karengineering mentioned this issue Oct 10, 2022
Merged
10 tasks
crenshaw-dev pushed a commit that referenced this issue Oct 11, 2022
@karengineering
fix: add applicationsets to RBAC policy (#10810) (#10891)
4583cca 
Signed-off-by: Karengineering <49111213+karengineering@users.noreply.github.com>

Signed-off-by: Karengineering <49111213+karengineering@users.noreply.github.com>
crenshaw-dev pushed a commit that referenced this issue Oct 11, 2022
@karengineering @crenshaw-dev
fix: add applicationsets to RBAC policy (#10810) (#10891)
2ccb960 
Signed-off-by: Karengineering <49111213+karengineering@users.noreply.github.com>

Signed-off-by: Karengineering <49111213+karengineering@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karengineering karengineering

Labels
bug Something isn't working cherry-pick/2.5 good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
v2.5
2 participants
@crenshaw-dev @karengineering