New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Modify examples for ArgoCD ApplicationSet Git Generator #10857
docs: Modify examples for ArgoCD ApplicationSet Git Generator #10857
Conversation
Signed-off-by: toyamagu <toyamagu2021@gmail.com>
Codecov ReportBase: 45.67% // Head: 45.67% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #10857 +/- ##
=======================================
Coverage 45.67% 45.67%
=======================================
Files 236 236
Lines 28698 28698
=======================================
Hits 13107 13107
Misses 13799 13799
Partials 1792 1792
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @toyamagu-2021! Just a couple suggestions given.
.../examples/git-generator-directory/excludes/git-directories-exclude-example-fasttemplate.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: toyamagu <toyamagu2021@gmail.com>
be7065b
to
be86572
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @toyamagu-2021!
* Doc: ArgoCD ApplicationSet Git directory Signed-off-by: toyamagu <toyamagu2021@gmail.com> * Docs: use "my-project" rather than default project Signed-off-by: toyamagu <toyamagu2021@gmail.com> Signed-off-by: toyamagu <toyamagu2021@gmail.com>
…10857) * Doc: ArgoCD ApplicationSet Git directory Signed-off-by: toyamagu <toyamagu2021@gmail.com> * Docs: use "my-project" rather than default project Signed-off-by: toyamagu <toyamagu2021@gmail.com> Signed-off-by: toyamagu <toyamagu2021@gmail.com> Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Cherry-picked onto release-2.4 for 2.4.15 and release-2.5 for 2.5.0-rc2. |
…10857) * Doc: ArgoCD ApplicationSet Git directory Signed-off-by: toyamagu <toyamagu2021@gmail.com> * Docs: use "my-project" rather than default project Signed-off-by: toyamagu <toyamagu2021@gmail.com> Signed-off-by: toyamagu <toyamagu2021@gmail.com> Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com>
…rgoproj#10857)" This reverts commit ed9a616.
…rgoproj#10857)" This reverts commit ed9a616.
* Wrap error objects to include context Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Revert "Wrap error objects to include context" This reverts commit d1789bd. Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * In Application Details, link the path field directly to the path in the repo Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * fix: duplicate source namespace validation (#10853) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * docs: fix examples for ArgoCD ApplicationSet Git Generator (#10857) * Doc: ArgoCD ApplicationSet Git directory Signed-off-by: toyamagu <toyamagu2021@gmail.com> * Docs: use "my-project" rather than default project Signed-off-by: toyamagu <toyamagu2021@gmail.com> Signed-off-by: toyamagu <toyamagu2021@gmail.com> Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Change 'branch' to 'src' Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Fix CR Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Fix CR Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * renaming Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Add comment Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: toyamagu <toyamagu2021@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: toyamagu <83329336+toyamagu-2021@users.noreply.github.com>
…oj#10860) * Wrap error objects to include context Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Revert "Wrap error objects to include context" This reverts commit d1789bd. Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * In Application Details, link the path field directly to the path in the repo Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * fix: duplicate source namespace validation (argoproj#10853) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * docs: fix examples for ArgoCD ApplicationSet Git Generator (argoproj#10857) * Doc: ArgoCD ApplicationSet Git directory Signed-off-by: toyamagu <toyamagu2021@gmail.com> * Docs: use "my-project" rather than default project Signed-off-by: toyamagu <toyamagu2021@gmail.com> Signed-off-by: toyamagu <toyamagu2021@gmail.com> Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Change 'branch' to 'src' Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Fix CR Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Fix CR Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * renaming Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> * Add comment Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: toyamagu <toyamagu2021@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: toyamagu <83329336+toyamagu-2021@users.noreply.github.com> Signed-off-by: Nicholas Johnson <nbjohnson10@gmail.com>
I modify the document about ArgoCD ApplicationSet Git Generator because:
apiextensions.k8s.io/v1beta1
which is no longer served as of v1.22.name: '{{path[0]}}'
, but we should use{{path.basename}}
name: '{{path[0]}}'
, this result in a duplicate Application name.And I have made additional minor changes.
Signed-off-by: toyamagu toyamagu2021@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: