Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking sync option label doesn't check corresponding box #10863

Closed
crenshaw-dev opened this issue Oct 8, 2022 · 2 comments · Fixed by #10876
Closed

Clicking sync option label doesn't check corresponding box #10863

crenshaw-dev opened this issue Oct 8, 2022 · 2 comments · Fixed by #10876
Labels
accessibility For improving the accessibility of UI bug Something isn't working cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5 component:ui User interfaces bugs and enhancements

Comments

@crenshaw-dev
Copy link
Collaborator

Describe the bug

When clicking the sync options label in the sync panel (when opened from the main Applications page), the corresponding checkbox is not checked.

To Reproduce

  1. Open the main Argo CD page (the Applications list)
  2. Click "sync" on any app
  3. Click any sync option label

Expected behavior

I expected a click on the sync option label to mark the checkbox.

Screenshots

Screen.Recording.2022-10-08.at.4.00.42.PM.mov

Version

2.5.0-rc1
@crenshaw-dev crenshaw-dev added bug Something isn't working component:ui User interfaces bugs and enhancements accessibility For improving the accessibility of UI cherry-pick/2.5 labels Oct 8, 2022
@crenshaw-dev
Copy link
Collaborator Author

I think the labels don't work because the checkboxes' id attributes are not unique within the page.

@Marvin9 Marvin9 mentioned this issue Oct 10, 2022
Merged
10 tasks
@crenshaw-dev crenshaw-dev added cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch labels Oct 10, 2022
@crenshaw-dev
Copy link
Collaborator Author

Reproduced the issue in 2.2-2.4.

crenshaw-dev pushed a commit that referenced this issue Oct 10, 2022
@Marvin9
fix(ui): sync option label doesn't check corresponding box (#10863) (#…
2aaf997 
…10876)

* fix(ui): sync option label doesn't check corresponding box

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

* fix: lint

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
crenshaw-dev pushed a commit that referenced this issue Oct 10, 2022
@Marvin9 @crenshaw-dev
fix(ui): sync option label doesn't check corresponding box (#10863) (#…
e0ffec8 
…10876)

* fix(ui): sync option label doesn't check corresponding box

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

* fix: lint

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
crenshaw-dev pushed a commit that referenced this issue Oct 10, 2022
@Marvin9 @crenshaw-dev
fix(ui): sync option label doesn't check corresponding box (#10863) (#…
8b78e94 
…10876)

* fix(ui): sync option label doesn't check corresponding box

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

* fix: lint

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
crenshaw-dev pushed a commit that referenced this issue Oct 10, 2022
@Marvin9 @crenshaw-dev
fix(ui): sync option label doesn't check corresponding box (#10863) (#…
96c13c1 
…10876)

* fix(ui): sync option label doesn't check corresponding box

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

* fix: lint

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
crenshaw-dev pushed a commit that referenced this issue Oct 10, 2022
@Marvin9 @crenshaw-dev
fix(ui): sync option label doesn't check corresponding box (#10863) (#…
7b0bb8d 
…10876)

* fix(ui): sync option label doesn't check corresponding box

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

* fix: lint

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility For improving the accessibility of UI bug Something isn't working cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5 component:ui User interfaces bugs and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): sync option label doesn't check corresponding box Marvin9/argo-cd
1 participant
@crenshaw-dev