Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): sync option label doesn't check corresponding box #10876

Merged
merged 2 commits into from Oct 10, 2022
Merged

fix(ui): sync option label doesn't check corresponding box #10876

merged 2 commits into from Oct 10, 2022

Conversation

Marvin9
Copy link
Contributor

@Marvin9 Marvin9 commented Oct 10, 2022

fixes #10863

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@Marvin9
fix(ui): sync option label doesn't check corresponding box
120f296 
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@Marvin9
fix: lint
d754a8f 
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@crenshaw-dev crenshaw-dev added cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5 labels Oct 10, 2022
crenshaw-dev
crenshaw-dev approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local test checks out. Thanks for the quick fix @Marvin9!

@crenshaw-dev crenshaw-dev merged commit 2aaf997 into argoproj:master Oct 10, 2022
crenshaw-dev pushed a commit that referenced this pull request Oct 10, 2022
@Marvin9 @crenshaw-dev
fix(ui): sync option label doesn't check corresponding box (#10863) (#…
e0ffec8 
…10876)

* fix(ui): sync option label doesn't check corresponding box

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

* fix: lint

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Oct 10, 2022
@Marvin9 @crenshaw-dev
fix(ui): sync option label doesn't check corresponding box (#10863) (#…
8b78e94 
…10876)

* fix(ui): sync option label doesn't check corresponding box

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

* fix: lint

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Oct 10, 2022
@Marvin9 @crenshaw-dev
fix(ui): sync option label doesn't check corresponding box (#10863) (#…
96c13c1 
…10876)

* fix(ui): sync option label doesn't check corresponding box

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

* fix: lint

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Oct 10, 2022
@Marvin9 @crenshaw-dev
fix(ui): sync option label doesn't check corresponding box (#10863) (#…
7b0bb8d 
…10876)

* fix(ui): sync option label doesn't check corresponding box

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

* fix: lint

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@crenshaw-dev
Copy link
Collaborator

Cherry-picked onto release-2.2 for 2.2.15, release-2.3 for 2.3.10, release-2.4 for 2.4.15, and release-2.5 for 2.5.0-rc2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking sync option label doesn't check corresponding box
2 participants
@Marvin9 @crenshaw-dev