fix: add full permission for admins to applicationsets in RBAC policy (#10810) #10891
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 45.62% // Head: 45.62% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #10891 +/- ##
=======================================
Coverage 45.62% 45.62%
=======================================
Files 236 236
Lines 28699 28699
=======================================
Hits 13093 13093
Misses 13805 13805
Partials 1801 1801 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
crenshaw-dev
changed the title
|
@karengineering can you sign off your commit? You can find instructions in the "Details" link beside the failed check. |
Signed-off-by: Karengineering <49111213+karengineering@users.noreply.github.com>
karengineering
force-pushed
the
10810-bug
branch
from
112ff0a
to
731c946
Compare
crenshaw-dev
approved these changes
Oct 11, 2022
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 11, 2022
|
Cherry-picked onto release-2.5 for 2.5.0-rc3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10810
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: