Strip whitespace from project role group names

[crenshaw-dev]

Summary

I think the API server should strip the leading/trailing whitespace from group names in project roles.

Motivation

Intuit had a project role where a group name had a trailing whitespace. I believe this was the result of an accidental copy/paste to the UI.

  roles:
  - description: admin
    groups:
    - 'group:Admins_99999 '
    name: admin
    policies:
    - p, proj:some-proj:admin, applications, *, some-proj/*, allow

Proposal

The API server should strip leading/trailing whitespace from group names before adding them.

Note: I'm assuming that leading/trailing whitespace is always invalid around group names. I think that's true, but please disagree if I'm wrong!

[utopian-monkey]

i wanna work on this

[crenshaw-dev]

@utopian-monkey go for it! Let me know if you need any help!

[The-Debarghya]

Where are the changes to be implemented?

[crenshaw-dev]

@The-Debarghya I think either in server/project/project.go's Update function (stripping whitespace on project update) or on the ProjectRole struct as a .GetTrimmedGroups() function. The latter approach is a bit more involved, but more thorough.

[rishu1601]

Hey @crenshaw-dev , let me know if this is up for grab, I don't see this issue as assigned