feat: make ARGOCD_GIT_MODULES_ENABLED configurable in argocd-cmd-params #10931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: doshianish8 <doshi.anish.s@gmail.com>
10 tasks
Codecov ReportBase: 45.82% // Head: 45.82% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #10931 +/- ##
=======================================
Coverage 45.82% 45.82%
=======================================
Files 236 236
Lines 28698 28698
=======================================
Hits 13150 13150
Misses 13738 13738
Partials 1810 1810
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
crenshaw-dev
approved these changes
Oct 13, 2022
nbjohnson
pushed a commit
to nbjohnson/argo-cd
that referenced
this pull request
Oct 18, 2022
…ms (argoproj#10931) Signed-off-by: doshianish8 <doshi.anish.s@gmail.com> Signed-off-by: doshianish8 <doshi.anish.s@gmail.com> Signed-off-by: Nicholas Johnson <nbjohnson10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: doshianish8 doshi.anish.s@gmail.com
Fixes #10157
Checklist:
Testing Doc:
Testing for ArgoCD issue #10157.pdf