Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make ARGOCD_GIT_MODULES_ENABLED configurable in argocd-cmd-params #10921

Conversation

doshianish8
Copy link
Contributor

@doshianish8 doshianish8 commented Oct 12, 2022

Fixes Issue #10157

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 45.62% // Head: 45.82% // Increases project coverage by +0.20% 🎉

Coverage data is based on head (df187b1) compared to base (c99669e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10921      +/-   ##
==========================================
+ Coverage   45.62%   45.82%   +0.20%     
==========================================
  Files         236      236              
  Lines       28699    28698       -1     
==========================================
+ Hits        13093    13150      +57     
+ Misses      13805    13738      -67     
- Partials     1801     1810       +9     
Impacted Files Coverage Δ
server/application/terminal.go 11.32% <0.00%> (-1.44%) ⬇️
pkg/apiclient/apiclient.go 1.10% <0.00%> (-0.16%) ⬇️
util/settings/settings.go 51.25% <0.00%> (ø)
pkg/apiclient/grpcproxy.go 0.00% <0.00%> (ø)
server/application/application.go 29.01% <0.00%> (+1.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@doshianish8
Copy link
Contributor Author

forgot to sign off commit, so closing this. Please refer this PR: #10931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants