Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Enhance title & description for Certificates on settings page #10956

Merged
merged 2 commits into from Oct 18, 2022
Merged

chore: Enhance title & description for Certificates on settings page #10956

merged 2 commits into from Oct 18, 2022

Conversation

aimanfatima
Copy link
Contributor

@aimanfatima aimanfatima commented Oct 14, 2022 •
edited by crenshaw-dev

Signed-off-by: Aiman Fatima aimanfatimadl@gmail.com
Closes #7560

Local testing -
image
image

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@aimanfatima aimanfatima mentioned this pull request Oct 14, 2022
Closed
@codecov
Copy link

codecov bot commented Oct 14, 2022 •
edited

Codecov Report

Base: 45.63% // Head: 45.63% // No change to project coverage 👍

Coverage data is based on head (241f197) compared to base (36c1a15).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #10956   +/-   ##
=======================================
  Coverage   45.63%   45.63%           
=======================================
  Files         237      237           
  Lines       28721    28721           
=======================================
  Hits        13108    13108           
  Misses      13809    13809           
  Partials     1804     1804

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

saumeya
saumeya suggested changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@saumeya saumeya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @aimanfatima, added a small comment.

ui/src/app/settings/components/settings-overview/settings-overview.tsx Outdated
@@ -13,8 +13,8 @@ const settings = [
path: './repos'
},
{
title: 'Certificates',
description: 'Configure certificates for connecting Git repositories',
title: 'Certificates and known hosts',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this also be 'Repository certificate and known hosts'. Just to make it consistent with the other settings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saumeya made the changes.
please note - I changed both title and description to Repository certificates

@aimanfatima aimanfatima requested review from saumeya and removed request for keithchong October 17, 2022 13:23
@aimanfatima
fix: Enhance title & description for Certificates on settings page
77220f4 
Signed-off-by: Aiman Fatima <aiman_fatima@intuit.com>
Signed-off-by: Aiman Fatima <aimanfatimadl@gmail.com>
@aimanfatima
fix: Review comments
241f197 
Signed-off-by: Aiman Fatima <aimanfatimadl@gmail.com>
@crenshaw-dev crenshaw-dev changed the title fix: Enhance title & description for Certificates on settings page chore: Enhance title & description for Certificates on settings page Oct 17, 2022
saumeya
saumeya approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@saumeya saumeya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@crenshaw-dev crenshaw-dev merged commit 40126b5 into argoproj:master Oct 18, 2022
nbjohnson pushed a commit to nbjohnson/argo-cd that referenced this pull request Oct 18, 2022
@aimanfatima @nbjohnson
chore: Enhance title & description for Certificates on settings page (a…
2c10b3a 
…rgoproj#7560) (argoproj#10956)

* fix: Enhance title & description for Certificates on settings page

Signed-off-by: Aiman Fatima <aiman_fatima@intuit.com>
Signed-off-by: Aiman Fatima <aimanfatimadl@gmail.com>

* fix: Review comments

Signed-off-by: Aiman Fatima <aimanfatimadl@gmail.com>

Signed-off-by: Aiman Fatima <aiman_fatima@intuit.com>
Signed-off-by: Aiman Fatima <aimanfatimadl@gmail.com>
Signed-off-by: Nicholas Johnson <nbjohnson10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

@saumeya saumeya saumeya approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better title and description for 'Certificates' on settings page
3 participants
@aimanfatima @crenshaw-dev @saumeya