Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better title and description for 'Certificates' on settings page #7560

Closed
lzm0 opened this issue Oct 27, 2021 · 6 comments · Fixed by #10956
Closed

Better title and description for 'Certificates' on settings page #7560

lzm0 opened this issue Oct 27, 2021 · 6 comments · Fixed by #10956
Assignees
@aimanfatima
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@lzm0
Copy link

lzm0 commented Oct 27, 2021

Summary

On /settings page, one of the cards has the title 'Certificates' while in fact the link it points to does not contain any certificates.
image

Motivation

This could be misleading as SSH keys are also configured in /settings/certs. SSH keys are not considered certificates.

Proposal

  1. Change the title 'Certificates' to 'Certificates and known hosts'.
  2. Change the description under that title accordingly.
  3. Change the title of the page linked from the card.
@lzm0 lzm0 added the enhancement New feature or request label Oct 27, 2021
@saumeya saumeya added the component:ui User interfaces bugs and enhancements label Jan 1, 2022
@saumeya saumeya self-assigned this Apr 4, 2022
@saumeya saumeya removed their assignment Aug 5, 2022
@saumeya saumeya added the good first issue Good for newcomers label Aug 5, 2022
@RyanTalbot
Copy link
Contributor

I can pick this up if still needed.

@saumeya
Copy link
Contributor

saumeya commented Aug 22, 2022

That would be great @RyanTalbot

@RyanTalbot
Copy link
Contributor

RyanTalbot commented Aug 22, 2022 •
edited

No problem, on it.

@aimanfatima
Copy link
Contributor

can I work on this issue?

@saumeya
Copy link
Contributor

saumeya commented Oct 11, 2022

Sure @aimanfatima, that would be awesome!

@aimanfatima aimanfatima mentioned this issue Oct 14, 2022
Merged
10 tasks
@aimanfatima
Copy link
Contributor

hi @saumeya @crenshaw-dev
created this pr - #10956
Please have a look and let me know.

crenshaw-dev pushed a commit that referenced this issue Oct 18, 2022
@aimanfatima
chore: Enhance title & description for Certificates on settings page (#…
40126b5 
…7560) (#10956)

* fix: Enhance title & description for Certificates on settings page

Signed-off-by: Aiman Fatima <aiman_fatima@intuit.com>
Signed-off-by: Aiman Fatima <aimanfatimadl@gmail.com>

* fix: Review comments

Signed-off-by: Aiman Fatima <aimanfatimadl@gmail.com>

Signed-off-by: Aiman Fatima <aiman_fatima@intuit.com>
Signed-off-by: Aiman Fatima <aimanfatimadl@gmail.com>
nbjohnson pushed a commit to nbjohnson/argo-cd that referenced this issue Oct 18, 2022
@aimanfatima @nbjohnson
chore: Enhance title & description for Certificates on settings page (a…
2c10b3a 
…rgoproj#7560) (argoproj#10956)

* fix: Enhance title & description for Certificates on settings page

Signed-off-by: Aiman Fatima <aiman_fatima@intuit.com>
Signed-off-by: Aiman Fatima <aimanfatimadl@gmail.com>

* fix: Review comments

Signed-off-by: Aiman Fatima <aimanfatimadl@gmail.com>

Signed-off-by: Aiman Fatima <aiman_fatima@intuit.com>
Signed-off-by: Aiman Fatima <aimanfatimadl@gmail.com>
Signed-off-by: Nicholas Johnson <nbjohnson10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aimanfatima aimanfatima

Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Enhance title & description for Certificates on settings page aimanfatima/argo-cd
5 participants
@crenshaw-dev @RyanTalbot @lzm0 @saumeya @aimanfatima