Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orphaned resources no longer have a distinct color in the UI #11180

Closed
3 tasks done
danieljkemp opened this issue Nov 3, 2022 · 3 comments · Fixed by #11218
Closed
3 tasks done

Orphaned resources no longer have a distinct color in the UI #11180

danieljkemp opened this issue Nov 3, 2022 · 3 comments · Fixed by #11218
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements

Comments

@danieljkemp
Copy link

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

Orphaned resources no longer have a distinct color in the UI.

To Reproduce

View an application in the UI, and select "Show Orphaned"

Expected behavior
In the past, orphaned resources were grayed out, and could be visually distinguished from non-orphaned objects.

Screenshots

image

Version

v2.5.1+504da42

Logs

N/A
@danieljkemp danieljkemp added the bug Something isn't working label Nov 3, 2022
@saumeya saumeya added the component:ui User interfaces bugs and enhancements label Nov 4, 2022
@danieljkemp
Copy link
Author

danieljkemp commented Nov 7, 2022 •
edited

Below is the example in the docs of what it should look like. In the screenshot above, both of the resources should be grey.

image
https://argo-cd.readthedocs.io/en/stable/user-guide/orphaned-resources/

@alexef
Copy link
Member

alexef commented Nov 7, 2022

I can confirm they show white and not grayed out. Will take a look at the code.

@alexef
Copy link
Member

alexef commented Nov 7, 2022

Seems like the problem was introduced along with themes:
Screenshot 2022-11-07 at 16 05 42

The fix is to add the class to the theme.

alexef added a commit to alexef/argo-cd that referenced this issue Nov 7, 2022
@alexef
fix(ui): show orphaned as gray. fixes: argoproj#11180
f24fa25 
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
@alexef alexef mentioned this issue Nov 7, 2022
Merged
10 tasks
rbreeze pushed a commit that referenced this issue Nov 9, 2022
@alexef
fix(ui): show orphaned as gray. fixes: #11180 (#11218)
4cf807e 
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this issue Nov 23, 2022
@alexef @ashutosh16
fix(ui): show orphaned as gray. fixes: argoproj#11180 (argoproj#11218)
0a95a42 
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
emirot pushed a commit to emirot/argo-cd that referenced this issue Jan 27, 2023
@alexef @emirot
fix(ui): show orphaned as gray. fixes: argoproj#11180 (argoproj#11218)
a1062c5 
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): show orphaned as gray. fixes: #11180 alexef/argo-cd
3 participants
@alexef @danieljkemp @saumeya