fix: remove 0.0.0.0/0 ipblock from network policies (#11321)

[f1ko]

Fixes #11321

Signed-off-by: Filip Nikolic oss.filipn@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[34fathombelow]

Thank you for your contribution. When adding the ipBlock I was trying to be explicit and was unaware cilium did not support this. It also appears GKE Dataplane V2 uses cilium which would also be unsupported.

This change makes sense. I have tested and confirmed your fix works locally and on GKE. Removing to and ipBlock results in the same policy.

k -n argocd describe networkpolicies.networking.k8s.io argocd-redis-ha-server-network-policy            
Name:         argocd-redis-ha-server-network-policy
Namespace:    argocd
Created on:   2022-11-16 21:37:26 -0800 PST
Labels:       <none>
Annotations:  <none>
Spec:
  PodSelector:     app.kubernetes.io/name=argocd-redis-ha
  Allowing ingress traffic:
    To Port: 6379/TCP
    To Port: 26379/TCP
    From:
      PodSelector: app.kubernetes.io/name=argocd-redis-ha-haproxy
    From:
      PodSelector: app.kubernetes.io/name=argocd-redis-ha
  Allowing egress traffic:
    To Port: 6379/TCP
    To Port: 26379/TCP
    To:
      PodSelector: app.kubernetes.io/name=argocd-redis-ha
    ----------
    To Port: 53/UDP
    To Port: 53/TCP
    To: <any> (traffic not restricted by destination)
  Policy Types: Ingress, Egress

LGTM!

[crenshaw-dev]

@zachaller fyi

[codecov]

Codecov Report

Base: 45.69% // Head: 45.69% // No change to project coverage 👍

Coverage data is based on head (a3b5b2b) compared to base (2173b87).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #11322   +/-   ##
=======================================
  Coverage   45.69%   45.69%           
=======================================
  Files         239      239           
  Lines       29013    29013           
=======================================
  Hits        13257    13257           
  Misses      13934    13934           
  Partials     1822     1822           

Impacted Files	Coverage Δ
util/settings/settings.go	51.25% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[zachaller]

Yea this looks good to me, my thought process was the same as @34fathombelow I like being explicit but if it is not support this change LGTM.

[crenshaw-dev]

Cherry-picked onto release-2.5 for 2.5.3.