Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6 RC1: sync status and sync result "More" buttons do nothing in multi-source apps #11760

Closed
crenshaw-dev opened this issue Dec 19, 2022 · 3 comments · Fixed by #11971
Closed
Assignees
Labels
bug Something isn't working cherry-pick/2.6 multi-source-apps Bugs or enhancements related to multi-source Applications.
Milestone

Comments

@crenshaw-dev
Copy link
Collaborator

Checklist:

Describe the bug

If I look at a multi-source Application's main page, "More" buttons for sync status and sync result do nothing.

To Reproduce

Use this app:

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: test
  namespace: argocd
spec:
  destination:
    namespace: default
    server: https://kubernetes.default.svc
  project: default
  sources:
  - ref: elastic
    repoURL: https://github.com/crenshaw-dev/values-file-repo
  - helm:
      valueFiles:
      - $elastic/values-prod.yaml
    path: helm-guestbook
    repoURL: https://github.com/argoproj/argocd-example-apps
    targetRevision: HEAD

View the app in the UI and go to the app summary page. Click one of the "More" buttons.

Expected behavior

I'm not sure what's wrong here. They should work.

Screenshots

image

Version

2.6.0-rc1

@crenshaw-dev crenshaw-dev added bug Something isn't working multi-source-apps Bugs or enhancements related to multi-source Applications. cherry-pick/2.6 labels Dec 19, 2022
@ishitasequeira ishitasequeira self-assigned this Dec 20, 2022
@crenshaw-dev crenshaw-dev added this to the v2.6 milestone Dec 21, 2022
@ankitcharolia
Copy link
Contributor

I am facing this issue too.

@crenshaw-dev
Copy link
Collaborator Author

@ishitasequeira I forget where we landed on this. Was there any progress?

@ishitasequeira
Copy link
Member

@crenshaw-dev, we were deciding whether we want to disable "More" buttons for multiple sources. Especially as we are not displaying details for all sources. I will take this up tomorrow and raise a PR with "More" button disabled and a tooltip explaining the reason.

crenshaw-dev pushed a commit that referenced this issue Jan 27, 2023
* disable More button for multiple sources

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* address comments

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* Addressed merge conflicts

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

---------

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
crenshaw-dev pushed a commit that referenced this issue Jan 27, 2023
* disable More button for multiple sources

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* address comments

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* Addressed merge conflicts

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

---------

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
emirot pushed a commit to emirot/argo-cd that referenced this issue Jan 27, 2023
…roj#11971)

* disable More button for multiple sources

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* address comments

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* Addressed merge conflicts

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

---------

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this issue Mar 14, 2023
…roj#11971)

* disable More button for multiple sources

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* address comments

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* Addressed merge conflicts

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

---------

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cherry-pick/2.6 multi-source-apps Bugs or enhancements related to multi-source Applications.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants