fix: disable More button for multiple sources #11971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crenshaw-dev
requested changes
Jan 12, 2023
ui/src/app/applications/components/application-status-panel/application-status-panel.tsx
Outdated
Show resolved
Hide resolved
crenshaw-dev
requested changes
Jan 12, 2023
ishitasequeira
changed the title
ishitasequeira
added
the
multi-source-apps
ishitasequeira
force-pushed
the
disable-more-button-multisource
branch
2 times, most recently
from
fafc313
to
37e6147
Compare
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
ishitasequeira
force-pushed
the
disable-more-button-multisource
branch
from
37e6147
to
9232584
Compare
Codecov ReportBase: 47.38% // Head: 47.38% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11971 +/- ##
=======================================
Coverage 47.38% 47.38%
=======================================
Files 245 245
Lines 41670 41670
=======================================
Hits 19745 19745
Misses 19937 19937
Partials 1988 1988 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
crenshaw-dev
approved these changes
Jan 27, 2023
crenshaw-dev
pushed a commit
that referenced
this pull request
Jan 27, 2023
* disable More button for multiple sources Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * address comments Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Addressed merge conflicts Signed-off-by: ishitasequeira <ishiseq29@gmail.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
|
Cherry-picked onto release-2.6 for 2.6.0-rc6. |
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
…roj#11971) * disable More button for multiple sources Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * address comments Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Addressed merge conflicts Signed-off-by: ishitasequeira <ishiseq29@gmail.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Mar 14, 2023
…roj#11971) * disable More button for multiple sources Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * address comments Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Addressed merge conflicts Signed-off-by: ishitasequeira <ishiseq29@gmail.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ishitasequeira ishiseq29@gmail.com
Fixes #11760
Screenshots for UI changes:
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: