-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misleading Readiness Gate error in Argo CD UI #13972
Comments
By my reading of the docs, even if the readiness gate statuses are set, but they are set to |
Makes sense. I will reiterate on readiness gates UI to avoid premature checks and report warning instead of error. |
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix(ui): soften readiness gate failure message (#13972) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * null check everything Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…proj#14076) * fix(ui): soften readiness gate failure message (argoproj#13972) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * null check everything Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Made some changes and will release them with 2.7.5. |
…proj#14076) (argoproj#14079) * fix(ui): soften readiness gate failure message (argoproj#13972) * null check everything --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
…proj#14076) * fix(ui): soften readiness gate failure message (argoproj#13972) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * null check everything Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…proj#14076) * fix(ui): soften readiness gate failure message (argoproj#13972) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * null check everything Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Describe the bug
Argo CD now provides a new error in the UI instructing the user that there is a problem with the Readiness Gates (See screenshot below). The logic in the UI validates the existence of a readiness gate in the Pod spec without a related condition in the status field. However this error is misleading as pods that are marked with readiness gates will always have a moment where this condition is not met and errors are often being displayed. If the controller responsible for updating the readiness gate is overloaded or just slow, the Pod won't have a related condition created for a while. It will eventually create the condition and the situation will be normalized. Users are confused with this new UI thinking that there is an actual problem with their application.
Suggestion:
Screenshots
Version
Argo CD 2.7.2
The text was updated successfully, but these errors were encountered: