Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pod log viewer should not scroll to bottom, if user has scrolled up #14050

Closed
alexec opened this issue Jun 14, 2023 · 0 comments · Fixed by #14107
Closed

Pod log viewer should not scroll to bottom, if user has scrolled up #14050

alexec opened this issue Jun 14, 2023 · 0 comments · Fixed by #14107
Assignees
@alexec
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements

Comments

@alexec
Copy link
Contributor

alexec commented Jun 14, 2023 •
edited

I think this is a pre-existing issue but it is quite annoying.

  1. Open the pod log viewer.
  2. Scroll up to find whatever you care about.
  3. Wait for new log line.
  4. Viewer scrolls to bottom. Cannot see what you care about.
  5. Go to 2
@alexec alexec added bug Something isn't working component:ui User interfaces bugs and enhancements labels Jun 14, 2023
@alexec alexec self-assigned this Jun 16, 2023
@alexec alexec mentioned this issue Jun 16, 2023
Merged
alexec added a commit to alexec/argo-cd that referenced this issue Jun 23, 2023
@alexec
fix(ui): Polish pod logs viewer. Fixes argoproj#14050
acc486b 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
crenshaw-dev pushed a commit that referenced this issue Jun 24, 2023
@alexec
fix(ui): Polish pod logs viewer (#14050) (#14107)
771012b 
* fix(ui): Polish pod logs viewer. Fixes #14050

Signed-off-by: Alex Collins <alex_collins@intuit.com>

* lint

Signed-off-by: Alex Collins <alex_collins@intuit.com>

* lint

Signed-off-by: Alex Collins <alex_collins@intuit.com>

* lint

Signed-off-by: Alex Collins <alex_collins@intuit.com>

---------

Signed-off-by: Alex Collins <alex_collins@intuit.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Jun 24, 2023
@alexec
fix(ui): Polish pod logs viewer (#14050) (#14107)
f0067a5 
* fix(ui): Polish pod logs viewer. Fixes #14050

Signed-off-by: Alex Collins <alex_collins@intuit.com>

* lint

Signed-off-by: Alex Collins <alex_collins@intuit.com>

* lint

Signed-off-by: Alex Collins <alex_collins@intuit.com>

* lint

Signed-off-by: Alex Collins <alex_collins@intuit.com>

---------

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this issue Jun 24, 2023
Merged
crenshaw-dev pushed a commit that referenced this issue Jun 25, 2023
@gcp-cherry-pick-bot @alexec
fix(ui): Polish pod logs viewer (#14050) (#14107) (#14193)
93b2228 
* fix(ui): Polish pod logs viewer. Fixes #14050



* lint



* lint



* lint



---------

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Co-authored-by: Alex Collins <alexec@users.noreply.github.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this issue Jul 24, 2023
@gcp-cherry-pick-bot @alexec @schakrad
fix(ui): Polish pod logs viewer (argoproj#14050) (argoproj#14107) (ar…
adb0215 
…goproj#14193)

* fix(ui): Polish pod logs viewer. Fixes argoproj#14050

* lint

* lint

* lint

---------

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Co-authored-by: Alex Collins <alexec@users.noreply.github.com>
Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this issue Aug 9, 2023
@alexec
fix(ui): Polish pod logs viewer (argoproj#14050) (argoproj#14107)
25a0425 
* fix(ui): Polish pod logs viewer. Fixes argoproj#14050

Signed-off-by: Alex Collins <alex_collins@intuit.com>

* lint

Signed-off-by: Alex Collins <alex_collins@intuit.com>

* lint

Signed-off-by: Alex Collins <alex_collins@intuit.com>

* lint

Signed-off-by: Alex Collins <alex_collins@intuit.com>

---------

Signed-off-by: Alex Collins <alex_collins@intuit.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this issue Dec 16, 2023
@alexec @tesla59
fix(ui): Polish pod logs viewer (argoproj#14050) (argoproj#14107)
072130c 
* fix(ui): Polish pod logs viewer. Fixes argoproj#14050

Signed-off-by: Alex Collins <alex_collins@intuit.com>

* lint

Signed-off-by: Alex Collins <alex_collins@intuit.com>

* lint

Signed-off-by: Alex Collins <alex_collins@intuit.com>

* lint

Signed-off-by: Alex Collins <alex_collins@intuit.com>

---------

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
bug Something isn't working component:ui User interfaces bugs and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): Polish pod logs viewer (#14050) alexec/argo-cd
1 participant
@alexec