Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo CD should detect unknown fields in invalid specs as OutOfSync #1787

Closed
jessesuen opened this issue Jun 19, 2019 · 2 comments · Fixed by argoproj/gitops-engine#154
Closed
Labels
bug Something isn't working component:core Syncing, diffing, cluster state cache
Milestone

Comments

@jessesuen
Copy link
Member

jessesuen commented Jun 19, 2019

If a user has the following in their git repo, we will not detect it as OutOfSync.

apiVersion: v1
kind: ConfigMap
metadata:
  name: invalid-cm
  annotations:
    argocd.argoproj.io/sync-options: Validate=false
invalidKey: asdf

This is because we drop invalidKey as part of remarshalling/normalization when we do comparisons.

@jessesuen jessesuen added the bug Something isn't working label Jun 19, 2019
@jessesuen
Copy link
Member Author

jessesuen commented Jun 19, 2019

This is not a common problem, because normally kubectl apply will prevent the deploy because it fails validation. The user would notice the failed sync and fix the problem in their git repo. They would need to disable validation to get to this bug.

@stale
Copy link

stale bot commented Aug 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 18, 2019
@alexmt alexmt removed the wontfix This will not be worked on label Aug 19, 2019
@alexec alexec added the M label Oct 4, 2019
@alexec alexec added this to the v1.4 milestone Oct 4, 2019
@alexmt alexmt modified the milestones: v1.4, v1.5 Jan 23, 2020
@alexmt alexmt modified the milestones: v1.5, v1.6 Feb 18, 2020
@alexmt alexmt removed the M label May 13, 2020
@jannfis jannfis added the component:core Syncing, diffing, cluster state cache label May 14, 2020
@alexmt alexmt modified the milestones: v1.6 GitOps Engine, v1.7 May 20, 2020
@alexmt alexmt modified the milestones: v1.7 , v1.8 Aug 25, 2020
alexmt added a commit to alexmt/argo-cd that referenced this issue Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:core Syncing, diffing, cluster state cache
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants