Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Application metrics. #18485

Open
CaMoPeZzz opened this issue Jun 3, 2024 · 2 comments
Open

Additional Application metrics. #18485

CaMoPeZzz opened this issue Jun 3, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@CaMoPeZzz
Copy link

Summary

Argocd web provides many fields on the application details page, but some of these fields are not available in application metrics (argocd_app_info, argocd_app_labels, etc). These fields can easily be added to application metrics, similar to those exported.

Motivation

Additional fields in metrics can be useful for building overview dashboards in grafana.

Proposal

For the "Target revision" field there are already several proposals (#4115, #12259).
The "URLs" and "Image" fields contain multiple values, so it is proposed to make separate metrics for them, for example argocd_app_image{default labels, image} and argocd_app_url{default labels, url}.
Additional metrics will lead to an increase in resource consumption, so I suggest making them optional, like argocd_app_labels.
I am ready to prepare PR if this proposal will be interesting to the community.

@CaMoPeZzz CaMoPeZzz added the enhancement New feature or request label Jun 3, 2024
@agaudreault
Copy link
Member

I think it is a good idea if they can be optional. You should update your proposal to evaluate different possible configurations and their pros and cons. 3 places that I see could contain configurations: global configuration, configuration in AppProject, configuration in Application resource.

@wouter2397
Copy link

I'm very interested in this. We now have 2 usecases which we want to monitor in alerting and dashboards:

  1. Monitor if auto-sync is enabled for an application.
  2. Monitor which target revision is configured

Our view is that both use cases can be best monitored by extending the metrics.
Very keen to see if this seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants