Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist environment parameters during deployment #27

Closed
1 of 2 tasks
alexmt opened this issue Mar 8, 2018 · 3 comments
Closed
1 of 2 tasks

Persist environment parameters during deployment #27

alexmt opened this issue Mar 8, 2018 · 3 comments
Milestone

Comments

@alexmt
Copy link
Collaborator

alexmt commented Mar 8, 2018

Each environment has parameters which are used to generate resources manifests. It would be useful to persist and display parameters which were used to deploy the application.

  • Persist parameters during deployment
  • Render parameters on application details page
@alexmt alexmt added this to the M2 milestone Mar 8, 2018
@merenbach
Copy link
Contributor

merenbach commented Mar 15, 2018

@alexmt Where could I go to start understanding how to do the first subtask? What would this "persisting" consist of—just making available to the UI through an API?

@alexmt
Copy link
Collaborator Author

alexmt commented Mar 15, 2018

@merenbach, right now we only need to show parameters to user. I would propose to store in Application CRD in AppStatus.RecentDeployment field:

// ApplicationStatus contains information about application status in target environment.
type ApplicationStatus struct {
	ComparisonResult ComparisonResult `json:"comparisonResult" protobuf:"bytes,1,opt,name=comparisonResult"`
// new field:
        RecentDeployment DeploymentInfo `json:"deploymentInfo" protobuf:"bytes,2,opt,name=deploymentInfo"`
}

RecentDeployment should be set in https://github.com/argoproj/argo-cd/blob/master/server/application/application.go#L117.

Parameters can be retrieved using ks param list --env <envNameHere>

@merenbach merenbach self-assigned this Mar 15, 2018
@merenbach
Copy link
Contributor

This is being worked on in the https://github.com/merenbach/argo-cd/tree/recent-deployments branch. Ksonnet data retrieval is implemented, and the RPC retrieval should be there (untested so far). To finish fleshing out, need to determine proper data structure for storing DeploymentInfo.

@merenbach merenbach removed their assignment Mar 16, 2018
@alexmt alexmt closed this as completed Apr 2, 2018
alexec pushed a commit that referenced this issue Apr 24, 2019
Issue #459 - Improve application creation wizard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants