Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the submodule fetch in a declarative way #3799

Open
zioalex opened this issue Jun 18, 2020 · 9 comments
Open

Disable the submodule fetch in a declarative way #3799

zioalex opened this issue Jun 18, 2020 · 9 comments
Labels
component:config-management Tools specific issues (helm, kustomize etc) enhancement New feature or request type:usability Enhancement of an existing feature

Comments

@zioalex
Copy link

zioalex commented Jun 18, 2020

Summary

It would be great to have the possibility to disable the sub-modules feature in a declarative way.
Today it is only possible globally as documented here https://argoproj.github.io/argo-cd/user-guide/private-repositories/#git-submodules

Ideally it would part of the Declarative Setup as defined here https://argoproj.github.io/argo-cd/operator-manual/declarative-setup/

Motivation

We have a project that doesn't need to fetch all the sub-modules in all the stages.
So it would be great if we can control such config in a declarative way.

Proposal

The idea is to have a feature toggle directly in the repo declaration like:

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: guestbook
  namespace: argocd
spec:
  project: default
  source:
    repoURL: https://github.com/argoproj/argocd-example-apps.git
    targetRevision: HEAD
    path: guestbook
    fetch_submodules: false
  destination:
    server: https://kubernetes.default.svc
    namespace: guestbook
@zioalex zioalex added the enhancement New feature or request label Jun 18, 2020
@zioalex zioalex changed the title Disable the submodule feature in a declarative way. Disable the submodule fetch in a declarative way. Jun 19, 2020
@zioalex zioalex mentioned this issue Jun 19, 2020
2 tasks
@jannfis jannfis added component:config-management Tools specific issues (helm, kustomize etc) type:usability Enhancement of an existing feature labels Jun 22, 2020
@wreed4
Copy link

wreed4 commented Dec 23, 2020

Is there a possibility of getting this in? I need to disable submodules for a single app, but don't want to disable globally and this is currently preventing me from using ArgoCD for this app.

@dohnto
Copy link

dohnto commented Feb 1, 2021

We would like to utilize this feature as well.

@redno2
Copy link

redno2 commented Jan 14, 2022

Especially useful if you have repo pointing to github.com, and your argocd is in offline mode, because of security constraints. The deployment fail like;

 ComparisonError
rpc error: code = Internal desc = Failed to checkout 7a34387fdf439e8a8f9f126703b1f3da709aa0d6: `git submodule update --init --recursive` failed exit status 1: Cloning into '/tmp/https:__github.*******_cicd_*******'... fatal: unable to access 'https://github.com/.......

@MaxWinterstein
Copy link

For everyone like me, who had no idea how to disable it globally,

kubectl set env deployment/argocd-repo-server ARGOCD_GIT_MODULES_ENABLED=false

@mattsfrey
Copy link

Another voice of support here, pulling submodules is causing a lot of issues for me.

@soudaburger
Copy link

For the helm chart:

repoServer:
  env:
    - name: ARGOCD_GIT_MODULES_ENABLED
      value: "false"

@crenshaw-dev
Copy link
Collaborator

I'd be in favor of a new field in the Application spec to disable submodules for a specific App.

Also trying to improve discoverability of the global config item: #10157

@crenshaw-dev crenshaw-dev changed the title Disable the submodule fetch in a declarative way. Disable the submodule fetch in a declarative way Aug 2, 2022
@sebastiangaiser
Copy link

I really like the idea of having it the declarative way as described in the proposal. Maybe this should also be configurable per Project.

MalibuKoKo added a commit to kube-components-stack/kustomization that referenced this issue Dec 23, 2022
… there are no solution to disable the submodule fetch in a declarative way cf. argoproj/argo-cd#3799
@ghost
Copy link

ghost commented Dec 19, 2023

How to use command parameters in the cli command to disable it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:config-management Tools specific issues (helm, kustomize etc) enhancement New feature or request type:usability Enhancement of an existing feature
Projects
None yet
Development

No branches or pull requests

10 participants