Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message truncated in UI when it is very long #4152

Closed
3 tasks done
jsoref opened this issue Aug 24, 2020 · 5 comments · Fixed by #4195
Closed
3 tasks done

Error message truncated in UI when it is very long #4152

jsoref opened this issue Aug 24, 2020 · 5 comments · Fixed by #4195
Assignees
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements type:usability Enhancement of an existing feature

Comments

@jsoref
Copy link
Member

jsoref commented Aug 24, 2020

If you are trying to resolve an environment-specific issue or have a one-off question about the edge case that does not require a feature then please consider asking a
question in argocd slack channel.

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

The error box is huge and yet nowhere near big enough to actually read the error. And it doesn't scroll well.

To Reproduce

  1. Navigate argocd to a pod
  2. Click the pod
  3. Click Edit in the Live Manifest
  4. Go to spec: > containers: > env:
  5. Add or otherwise change the environment
  6. Click save

Expected behavior

  1. Ideally if you know my changes aren't valid, don't let me try to save them
  2. The view should scroll wrap/something so I can read the content, it doesn't -- I have to select all and copy to a text editor to read it.

Screenshots

image

Unable to save changes: Pod "github-runner-76cff478cd-8bfqg" is invalid: spec: Forbidden: pod updates may not change fields other than spec.containers[*].image, spec.initContainers[*].image, spec.activeDeadlineSeconds or spec.tolerations (only additions to existing tolerations)

Version

v1.6.1+159674e

Logs

@jsoref jsoref added the bug Something isn't working label Aug 24, 2020
@jessesuen jessesuen added component:ui User interfaces bugs and enhancements type:usability Enhancement of an existing feature labels Aug 24, 2020
@rbreeze rbreeze self-assigned this Aug 27, 2020
@rbreeze
Copy link
Member

rbreeze commented Aug 27, 2020

Unable to save changes: Pod "github-runner-76cff478cd-8bfqg" is invalid: spec: Forbidden: pod updates may not change fields other than spec.containers[].image, spec.initContainers[].image, spec.activeDeadlineSeconds or spec.tolerations (only additions to existing tolerations)

@jsoref is this how you would like the error message to be formatted? or are you seeing this somewhere else?

@jsoref
Copy link
Member Author

jsoref commented Aug 27, 2020

@rbreeze: that's just some of the text from the red error box.

No, it isn't how I'd like it formatted.

@rbreeze
Copy link
Member

rbreeze commented Aug 28, 2020

@jsoref Unfortunately we can't tell this YAML is invalid until it's sent to the server. We do validate the YAML before sending it, and when it's invalid it displays a nicely formatted error message; in this case the server is sending back a not-so-nicely formatted message, which is what you're seeing. For now, I'll make sure it's scrollable.

@rbreeze
Copy link
Member

rbreeze commented Aug 28, 2020

#4195

@rbreeze rbreeze linked a pull request Oct 20, 2020 that will close this issue
5 tasks
@rbreeze rbreeze changed the title Bad UX making edits to a live pod manifest Error message truncated in UI when it is very long Feb 5, 2021
@jsoref
Copy link
Member Author

jsoref commented Apr 29, 2022

I should note that technically there wasn't anything wrong w/ the yaml validity, it's just that k8s doesn't allow mutations of certain fields. It might be possible to know this, but that's outside the scope of this issue.

rbreeze added a commit that referenced this issue Apr 29, 2022
Co-authored-by: Michael Crenshaw <michael@crenshaw.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements type:usability Enhancement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants