-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/api/v1/applications takes significant amount of time #4296
Comments
Same issue, we are using v1.7.4 |
Also, I've notice, that if login using built-in account to the same api server response more quickly. |
NOTE: The admin is special because it has no groups and therefore enforcement is simpler.
I think we need an optimization to use a temporary map to lookup oidc groups rather than current implementation to iterate the groups list |
Great news if this is solved with 1.8! |
Looking into this. |
#5342 is a workaround for this, but ideally we should still implement a map for OIDC group lookup |
Discussed with @jessesuen and we feel pagination addresses the user experience of slow loading apps. |
Part of: argoproj#4296 Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
* chore: pre filter groups before enforcing Part of: #4296 Signed-off-by: Jan Jansen <jan.jansen@gdata.de> * chore: prevent serialization if it is a mapclaims Signed-off-by: Jan Jansen <jan.jansen@gdata.de> * add comments Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
Hello @cedricboesiger, @boskoop , The v2.1 has a optimization that is supposed to significantly improve API server performance. The change is available in https://github.com/argoproj/argo-cd/releases/tag/v2.1.0-rc1. Can you give it a try please? |
Closing and will reopen if someone reproduce issue again |
@alexmt is there any progress on the overall application list slowness issue? we have 4k applications now and the application listing cost about 8-10 seconds at least, even if we only assign an admin role to the user. |
feat: cache argo cd rbac (argoproj#7587) Part of: argoproj#4296 Signed-off-by: Jan Jansen <jan.jansen@gdata.de> Signed-off-by: pashavictorovich <pavel@codefresh.io> Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: lukasz.peplinski <lukpep@gmail.com>
@yydzhou the API was improved in v2.2. During performance testing, we've reduced API response time from 10 seconds to ~0.5 seconds. Can you please give it a try? |
still happens on v2.3.3 with 23 clusters and 1612 applications. |
still happens on v2.4.6 with 10 clusters and 50 applications |
With v2.4.17 it can still take 5+ seconds for 1000+ apps to load |
Same here. 3k+ apps, 1 cluster, v2.4.11 Sometimes it take 30s+ :sad: |
Would y'all be willing to test this? #11884 |
Does the endpoint |
Describe the bug
The application list page uses GET /api/v1/applications?fields=... which, depending on the number of projects holding OIDC groups, requires more time to answer the request.
In our environment, it already takes between 12s-14s to answer the request.
We count:
To Reproduce
Expected behavior
A response time that is less dependent on the number of applications, projects and groups involved.
The text was updated successfully, but these errors were encountered: