Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent autosync reconcile after rollback #5351

Open
anjmao opened this issue Jan 29, 2021 · 1 comment
Open

Prevent autosync reconcile after rollback #5351

anjmao opened this issue Jan 29, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@anjmao
Copy link

anjmao commented Jan 29, 2021

Summary

Our argo application CRD manifests placed inside git repository which also contains services which we deploy. By default we enabled auto sync policy for both dev and prod environments. I needed to rollback prod environment and auto sync disabled automatically which is expected. But later as new deployment was triggered to that git repository argo synced back argo application CRD and enabled auto sync so broken version was released back to prod.

Proposal

If rollback was performed sync policy could be updated by adding manual: true, eg:

syncPolicy:
    manual: true
    automated:
      prune: true
      selfHeal: true

During reconcile argo would need to check if sync policy is set to manual and skip updating it so user is responsible for enabling automated sync back.

Also it would be great to show sync policy status in argo UI as currently there is no clear indication that rollback was performed and automated sync is stopped until user enables it manually.

@anjmao anjmao added the enhancement New feature or request label Jan 29, 2021
@alexef
Copy link
Member

alexef commented Apr 14, 2023

this also relates to #8686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants