Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network view should group pods into higher level workload #5468

Closed
jessesuen opened this issue Feb 9, 2021 · 3 comments · Fixed by #8996
Closed

Network view should group pods into higher level workload #5468

jessesuen opened this issue Feb 9, 2021 · 3 comments · Fixed by #8996
Assignees
@keithchong
Labels
enhancement New feature or request

Comments

@jessesuen
Copy link
Member

Summary

The network view does not look good when you have a large application with many pods.

image

Most of the time, users don't care how traffic is routed to individual pods, but rather to some higher level workload that created that pod (e.g. ReplicaSet).

Proposal

Instead of showing lines to many pods, we should connect the service to the parent of the pod. Possibly leveraging what we did in the pod view:

image
@jessesuen jessesuen added the enhancement New feature or request label Feb 9, 2021
@jessesuen jessesuen mentioned this issue Feb 16, 2021
Closed
@jessesuen
Copy link
Member Author

Whoever fixes this, please also right justify the network view

@jessesuen jessesuen added this to the v1.10 milestone Feb 23, 2021
@alexmt alexmt modified the milestones: v2.1, v2.2 Jul 2, 2021
@rbreeze rbreeze modified the milestones: v2.2, v2.3 Nov 5, 2021
@rbreeze
Copy link
Member

rbreeze commented Jan 13, 2022

This was addressed for the normal tree view, but not the network tree view

@alexmt alexmt removed this from the v2.3 milestone Jan 19, 2022
@keithchong keithchong self-assigned this Feb 10, 2022
@keithchong keithchong mentioned this issue Mar 3, 2022
Merged
10 tasks
@keithchong
Copy link
Contributor

Maybe something like this:

podGroups-NetworkView.mov

@keithchong keithchong mentioned this issue Apr 5, 2022
Merged
10 tasks
@keithchong keithchong mentioned this issue May 9, 2022
Open
keithchong added a commit to keithchong/argo-cd that referenced this issue May 9, 2022
@keithchong
feat: Network view should group pods into higher level workload (argo…
9ffbe39 
…proj#5468)

Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong added a commit that referenced this issue May 12, 2022
@keithchong
feat: Network view should group pods into higher level workload (#5468)…
cb85f23 
… (#8996)

Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong added a commit to keithchong/argo-cd that referenced this issue May 13, 2022
@keithchong
fix: Pass context to resource tree (argoproj#5468)
8be597d 
Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong keithchong mentioned this issue May 13, 2022
Merged
10 tasks
alexmt pushed a commit that referenced this issue May 13, 2022
@keithchong
fix: Pass context to resource tree (#5468) (#9401)
1186fee 
Signed-off-by: Keith Chong <kykchong@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keithchong keithchong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Network view should group pods into higher level workload (#5468) keithchong/argo-cd
4 participants
@alexmt @rbreeze @keithchong @jessesuen