Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes client logging (--gloglevel) stopped working #5697

Closed
jessesuen opened this issue Mar 5, 2021 · 1 comment
Closed

kubernetes client logging (--gloglevel) stopped working #5697

jessesuen opened this issue Mar 5, 2021 · 1 comment
Assignees
@kshamajain99
Labels
bug Something isn't working regression Bug is a regression, should be handled with high priority
Milestone
v2.0

Comments

@jessesuen
Copy link
Member

jessesuen commented Mar 5, 2021 •
edited

When attempting to debug a kubernetes issue and enable kubernetes client logging using our --gloglevel flag to api-server and controller, this no longer works. This was attempted on v2.0 (7ad79e5)
@jessesuen jessesuen added bug Something isn't working regression Bug is a regression, should be handled with high priority labels Mar 5, 2021
@jessesuen jessesuen added this to the v2.0 milestone Mar 5, 2021
@kshamajain99 kshamajain99 self-assigned this Mar 5, 2021
@kshamajain99
Copy link
Contributor

kshamajain99 commented Mar 5, 2021 •
edited

Logging broke because k8s.io moved to klog/v2. Whereas argo-cd cli is setting verbose level to klog/v1.

This problem can be solved by either:

  1. moving argo-cd cli to use klog/v2
  2. coexist klog/v1 and klog/v2 https://github.com/kubernetes/klog/blob/master/examples/coexist_klog_v1_and_v2/coexist_klog_v1_and_v2.go

alexmt pushed a commit that referenced this issue Mar 5, 2021
@kshamajain99
fix: upgrade klog (#5697) (#5699)
c0985fb 
fix: upgrade klog (#5697) (#5699)
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this issue Apr 15, 2021
@kshamajain99 @Shubhama19
fix: upgrade klog (argoproj#5697) (argoproj#5699)
7cad633 
fix: upgrade klog (argoproj#5697) (argoproj#5699)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kshamajain99 kshamajain99

Labels
bug Something isn't working regression Bug is a regression, should be handled with high priority
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
2 participants
@kshamajain99 @jessesuen