Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Version warning banner in docs #6682

Merged

Conversation

saumeya
Copy link
Contributor

@saumeya saumeya commented Jul 9, 2021

Signed-off-by: saumeya saumeyakatyal@gmail.com
Closes #6624
Screenshot from 2021-07-09 16-03-42

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #6682 (c2ca426) into master (f12650c) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head c2ca426 differs from pull request most recent head 17eb524. Consider uploading reports for the commit 17eb524 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6682   +/-   ##
=======================================
  Coverage   41.29%   41.30%           
=======================================
  Files         156      156           
  Lines       20688    20702   +14     
=======================================
+ Hits         8543     8550    +7     
- Misses      10937    10944    +7     
  Partials     1208     1208           
Impacted Files Coverage Δ
cmd/argocd-util/commands/app.go 31.30% <0.00%> (-0.28%) ⬇️
cmd/argocd/commands/root.go 2.17% <0.00%> (-0.05%) ⬇️
cmd/argocd/commands/app.go 0.00% <0.00%> (ø)
cmd/util/app.go 36.87% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12650c...17eb524. Read the comment docs.

@jannfis
Copy link
Member

jannfis commented Jul 10, 2021

Thanks @saumeya! Can you please fix the DCO check by signing off your commits?

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

add side-bar media queries

removed extra comments

Signed-off-by: saumeya <saumeyakatyal@gmail.com>
@saumeya saumeya force-pushed the make-version-warning-banner-sticky-624 branch from c2ca426 to 17eb524 Compare July 11, 2021 07:58
@saumeya
Copy link
Contributor Author

saumeya commented Jul 11, 2021

Thanks @saumeya! Can you please fix the DCO check by signing off your commits?

Done

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @saumeya!

@jannfis jannfis merged commit da3f21b into argoproj:master Jul 11, 2021
@jannfis jannfis added cherry-pick/1.8 Candidate for cherry picking into the 1.8 release branch cherry-pick/2.0 Candidate for cherry picking into the 2.0 release branch labels Jul 11, 2021
@jannfis
Copy link
Member

jannfis commented Jul 11, 2021

Going to cherry-pick this change into release-1.8 and release-2.0 branches so looking at older docs will produce the same sticky banner. FYI @alexmt

jannfis pushed a commit that referenced this pull request Jul 11, 2021
Signed-off-by: saumeya <saumeyakatyal@gmail.com>

add side-bar media queries

removed extra comments

Signed-off-by: saumeya <saumeyakatyal@gmail.com>
jannfis pushed a commit that referenced this pull request Jul 11, 2021
Signed-off-by: saumeya <saumeyakatyal@gmail.com>

add side-bar media queries

removed extra comments

Signed-off-by: saumeya <saumeyakatyal@gmail.com>
@jannfis jannfis self-assigned this Jul 13, 2021
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jul 13, 2021
@agilgur5 agilgur5 added documentation Issue is related to missing or incorrect documentation type:docs Missing or incomplete documentation labels Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/1.8 Candidate for cherry picking into the 1.8 release branch cherry-pick/2.0 Candidate for cherry picking into the 2.0 release branch documentation Issue is related to missing or incorrect documentation needs-verification PR requires pre-release verification type:docs Missing or incomplete documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the Unstable Docs Version Warning banner to Header
3 participants