New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Version warning banner in docs #6682
fix: Version warning banner in docs #6682
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6682 +/- ##
=======================================
Coverage 41.29% 41.30%
=======================================
Files 156 156
Lines 20688 20702 +14
=======================================
+ Hits 8543 8550 +7
- Misses 10937 10944 +7
Partials 1208 1208
Continue to review full report at Codecov.
|
Thanks @saumeya! Can you please fix the DCO check by signing off your commits? |
Signed-off-by: saumeya <saumeyakatyal@gmail.com> add side-bar media queries removed extra comments Signed-off-by: saumeya <saumeyakatyal@gmail.com>
c2ca426
to
17eb524
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @saumeya!
Going to cherry-pick this change into release-1.8 and release-2.0 branches so looking at older docs will produce the same sticky banner. FYI @alexmt |
Signed-off-by: saumeya <saumeyakatyal@gmail.com> add side-bar media queries removed extra comments Signed-off-by: saumeya <saumeyakatyal@gmail.com>
Signed-off-by: saumeya <saumeyakatyal@gmail.com> add side-bar media queries removed extra comments Signed-off-by: saumeya <saumeyakatyal@gmail.com>
Signed-off-by: saumeya saumeyakatyal@gmail.com
Closes #6624
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: