fix: allow argocd-notification ingress to repo-server #6746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows an argocd-notification installation using the provided manifests to ingress to the repo-server. I am not sure if there is a prevailing opinion about how to manage a cross project network policy for these related components so I thought I would put up a PR to spark that discussion. This could live in a separate NetworkPolicy object managed by the argocd-notifications manifests but I thought it wuold be better for the possible ingresses for the argocd project to all live in the argo-cd manifests. I know that notifications are an optional component, so maybe this is better provided as a separate manifest that can be strategic merged in? (I am a kustomize user). Regardless, I think this policy is something that be maintained by argoproj in some form to reduce release burden of users trying to hand maintain network policies. Signed-off-by: Tyler Dixon <tdixon@buf.build>
ZymoticB
changed the title
alexmt
approved these changes
Jul 16, 2021
|
Do I need to amend my commit to resolve the Semantic Pull Request check? Happy for you to edit / push an empty commit as is needed. Thanks! |
|
@ZymoticB it is ok - semantic title check is optional . Mering PR once tests are green. |
|
@ZymoticB , Please run |
Signed-off-by: Tyler Dixon <tdixon@buf.build>
|
Done! |
Codecov Report
@@ Coverage Diff @@
## master #6746 +/- ##
==========================================
+ Coverage 41.30% 41.31% +0.01%
==========================================
Files 156 156
Lines 20702 20709 +7
==========================================
+ Hits 8550 8556 +6
+ Misses 10944 10942 -2
- Partials 1208 1211 +3
Continue to review full report at Codecov.
|
alexmt
pushed a commit
that referenced
this pull request
Jul 22, 2021
* Allow argocd-notification ingress to repo-server This change allows an argocd-notification installation using the provided manifests to ingress to the repo-server. I am not sure if there is a prevailing opinion about how to manage a cross project network policy for these related components so I thought I would put up a PR to spark that discussion. This could live in a separate NetworkPolicy object managed by the argocd-notifications manifests but I thought it wuold be better for the possible ingresses for the argocd project to all live in the argo-cd manifests. I know that notifications are an optional component, so maybe this is better provided as a separate manifest that can be strategic merged in? (I am a kustomize user). Regardless, I think this policy is something that be maintained by argoproj in some form to reduce release burden of users trying to hand maintain network policies. Signed-off-by: Tyler Dixon <tdixon@buf.build> * make manifests Signed-off-by: Tyler Dixon <tdixon@buf.build>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows an argocd-notification installation using the provided
manifests to ingress to the repo-server.
I am not sure if there is a prevailing opinion about how to manage a
cross project network policy for these related components so I thought
I would put up a PR to spark that discussion. This could live in a separate
NetworkPolicy object managed by the argocd-notifications manifests but I
thought it wuold be better for the possible ingresses for the argocd project
to all live in the argo-cd manifests. I know that notifications are an optional
component, so maybe this is better provided as a separate manifest that can
be strategic merged in? (I am a kustomize user).
Regardless, I think this policy is something that be maintained by argoproj
in some form to reduce release burden of users trying to hand maintain network
policies.
Fixes #argoproj-labs/argocd-notifications#294
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: