Fix: Kuberenetes manifest to have new Github.com ssh known host keys for ArgoCD deployments #7722

smark88 · 2021-11-16T19:39:34Z

Issue: Applications now in Unknown state due to the link below

https://github.blog/2021-09-01-improving-git-protocol-security-github/

fix: Add new github.com ssh known host key

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

…yments https://github.blog/2021-09-01-improving-git-protocol-security-github/ Signed-off-by: smark88 <msarcevicz@influxdata.com>

Signed-off-by: smark88 <msarcevicz@influxdata.com>

crisp2u · 2021-11-16T20:17:31Z

I was just banging my head with this, thanks!

mfridman · 2021-11-16T20:18:17Z

I was just banging my head with this, thanks! x2

Although I still don't understand why this affected argo because the RSA key was still valid?
https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints

rizzza · 2021-11-16T20:26:28Z

saved our day, thank you!

codecov · 2021-11-16T20:35:41Z

Codecov Report

Merging #7722 (ecdcca8) into master (09c5d5f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7722   +/-   ##
=======================================
  Coverage   41.48%   41.48%           
=======================================
  Files         163      163           
  Lines       21960    21960           
=======================================
  Hits         9111     9111           
  Misses      11558    11558           
  Partials     1291     1291

Impacted Files	Coverage Δ
util/settings/settings.go	`46.83% <0.00%> (ø)`
cmd/argocd/commands/cluster.go	`5.68% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c5d5f...ecdcca8. Read the comment docs.

joaopaulosr95

Thanks for being so fast @smark88

smark88 · 2021-11-16T21:48:17Z

Should i wait on the tests to merge? Or is this ok since its so minor.

Kampe · 2021-11-16T22:18:24Z

looks like tests need to be updated

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

alexmt · 2021-11-17T05:51:12Z

Thanks a lot for a quick fix, @smark88 ! CI failed due to codegen minor difference in generated install.yaml files. The make manifests should fix it. For the sake of time, I pushed the fix into your fork. Merging PR as soon as CI is green.

…for ArgoCD deployments (#7722) * Kuberenetes manifest to have new ssh known host keys for ArgoCD deployments https://github.blog/2021-09-01-improving-git-protocol-security-github/ Signed-off-by: smark88 <msarcevicz@influxdata.com> * added to docs Signed-off-by: smark88 <msarcevicz@influxdata.com> * fix: regenerate manifests using 'make manifests' Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): Add Error Boundary around Extensions and comply with new Extensions API (argoproj#7215) * fix: Add error boundary around Extensions and change path where UI looks for extensions Signed-off-by: Remington Breeze <remington@breeze.software> * Add error message to error boundary Signed-off-by: Remington Breeze <remington@breeze.software> * docs: Kustomize load_restrictor -> load-restrictor (argoproj#7358) Signed-off-by: Jan-Otto Kröpke <joe@adorsys.de> * docs: update v2.3+ roadmap (argoproj#7353) * docs: update v2.3+ roadmap Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Address reviewer notes: Add 'Merge Argo CD Image Updater into Argo CD' and 'Multi-tenancy improvements' Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: remove not existing repo (argoproj#7280) * remove not existing repo Signed-off-by: pashavictorovich <pavel@codefresh.io> * fix test Signed-off-by: pashavictorovich <pavel@codefresh.io> * fix: Application status panel shows Syncing instead of Deleting (argoproj#7486) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: Operation has completed with phase: Running (argoproj#7482) * fix: Operation has completed with phase: Running Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Bump version to 2.1.4 * Bump version to 2.1.4 * fix: Invalid memory address or nil pointer dereference in processRequestedAppOperation (argoproj#7501) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Bump version to 2.1.5 * Bump version to 2.1.5 * fix: supporting OCI dependencies. Fixes argoproj#6062 (argoproj#6994) * fix: supporting OCI dependencies Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com> * chore: add org to USERS.md Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com> * fix(tests): remove invalid TestRepoPermission e2e test Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com> * fix: don't use revision caching during app creation (argoproj#7508) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Bump version to 2.1.6 * Bump version to 2.1.6 * Fix: Kuberenetes manifest to have new Github.com ssh known host keys for ArgoCD deployments (argoproj#7722) * Kuberenetes manifest to have new ssh known host keys for ArgoCD deployments https://github.blog/2021-09-01-improving-git-protocol-security-github/ Signed-off-by: smark88 <msarcevicz@influxdata.com> * added to docs Signed-off-by: smark88 <msarcevicz@influxdata.com> * fix: regenerate manifests using 'make manifests' Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Bump version to 2.1.7 * Bump version to 2.1.7 * fix: upgraded gitops engine to v0.4.2 (fixes argoproj#7561) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: env vars to tune cluster cache were broken (argoproj#7779) Signed-off-by: Jesse Suen <jesse@akuity.io> * fix nil point (argoproj#7905) Signed-off-by: jomenxiao <jomenxiao@gmail.com> * fix: issue with keepalive (argoproj#7861) * fix issue with keepalive Signed-off-by: pashavictorovich <pavel@codefresh.io> * empty commit Signed-off-by: pashavictorovich <pavel@codefresh.io> * Bump version to 2.1.8 * Bump version to 2.1.8 * Merge pull request from GHSA-63qx-x74g-jcr7 Signed-off-by: jannfis <jann@mistrust.net> * Bump version to 2.1.9 * Bump version to 2.1.9 * fix: Resolve symlinked value files correctly (argoproj#8387) * fix: Resolve symlinked value files correctly Signed-off-by: jannfis <jann@mistrust.net> * fix: Resolve symlinked value files correctly Signed-off-by: jannfis <jann@mistrust.net> * Bump version to 2.1.10 * Bump version to 2.1.10 * add CODEFRESH=true to e2e workflow * codegen * fix e2e Co-authored-by: Remington Breeze <remington@breeze.software> Co-authored-by: Jan-Otto Kröpke <github@jkroepke.de> Co-authored-by: Alexander Matyushentsev <Alexander_Matyushentsev@intuit.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Co-authored-by: argo-bot <argoproj@gmail.com> Co-authored-by: Mohammad Yosefpor <47300215+m-yosefpor@users.noreply.github.com> Co-authored-by: Mark Sarcevicz <47335998+smark88@users.noreply.github.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Jesse Suen <jessesuen@users.noreply.github.com> Co-authored-by: jomenxiao <jomenxiao@gmail.com> Co-authored-by: jannfis <jann@mistrust.net>

Adds the missing Github.com keys added after https://github.blog/2021-09-01-improving-git-protocol-security-github/ Related to argoproj/argo-cd#7722

smark88 added 2 commits November 16, 2021 14:40

Kuberenetes manifest to have new ssh known host keys for ArgoCD deplo…

c556694

…yments https://github.blog/2021-09-01-improving-git-protocol-security-github/ Signed-off-by: smark88 <msarcevicz@influxdata.com>

added to docs

6daeafd

Signed-off-by: smark88 <msarcevicz@influxdata.com>

smark88 force-pushed the manifest-add-new-github-ssh-knownhostkeys branch from 8cbce81 to 6daeafd Compare November 16, 2021 19:41

smark88 changed the title ~~Kuberenetes manifest to have new ssh known host keys for ArgoCD deployments~~ Fix: Kuberenetes manifest to have new ssh known host keys for ArgoCD deployments Nov 16, 2021

smark88 changed the title ~~Fix: Kuberenetes manifest to have new ssh known host keys for ArgoCD deployments~~ Fix: Kuberenetes manifest to have new Github.com ssh known host keys for ArgoCD deployments Nov 16, 2021

jannfis added cherry-pick/2.0 Candidate for cherry picking into the 2.0 release branch cherry-pick/2.1 Candidate for cherry picking into the 2.1 release branch labels Nov 16, 2021

jannfis mentioned this pull request Nov 16, 2021

SSH connections to github.com stopped working with host key mismatch #7723

Closed

joaopaulosr95 approved these changes Nov 16, 2021

View reviewed changes

mythxn approved these changes Nov 17, 2021

View reviewed changes

devanshmshah approved these changes Nov 17, 2021

View reviewed changes

fix: regenerate manifests using 'make manifests'

ecdcca8

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

alexmt approved these changes Nov 17, 2021

View reviewed changes

alexmt merged commit 18a1b07 into argoproj:master Nov 17, 2021

This was referenced Nov 17, 2021

ssh validation error should have more information #7725

Open

Host key mismatch #7736

Closed

Update github known_hosts entries #7729

Closed

jsoref mentioned this pull request Jan 25, 2022

Ingest https://api.github.com/meta #8271

Open

raelga added a commit to raelga/argocd-operator that referenced this pull request Jul 14, 2022

fix: adds missing github.com host keys

6945422

Adds the missing Github.com keys added after https://github.blog/2021-09-01-improving-git-protocol-security-github/ Related to argoproj/argo-cd#7722

raelga mentioned this pull request Jul 14, 2022

fix: add missing github.com host keys argoproj-labs/argocd-operator#725

Merged

tksm mentioned this pull request May 16, 2023

feat: add ssh.github.com to SSH known hosts #13592

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Kuberenetes manifest to have new Github.com ssh known host keys for ArgoCD deployments #7722

Fix: Kuberenetes manifest to have new Github.com ssh known host keys for ArgoCD deployments #7722

smark88 commented Nov 16, 2021 •

edited

crisp2u commented Nov 16, 2021

mfridman commented Nov 16, 2021 •

edited

rizzza commented Nov 16, 2021

codecov bot commented Nov 16, 2021 •

edited

joaopaulosr95 left a comment

smark88 commented Nov 16, 2021 •

edited

Kampe commented Nov 16, 2021

alexmt commented Nov 17, 2021 •

edited

Fix: Kuberenetes manifest to have new Github.com ssh known host keys for ArgoCD deployments #7722

Fix: Kuberenetes manifest to have new Github.com ssh known host keys for ArgoCD deployments #7722

Conversation

smark88 commented Nov 16, 2021 • edited

Issue: Applications now in Unknown state due to the link below

fix: Add new github.com ssh known host key

crisp2u commented Nov 16, 2021

mfridman commented Nov 16, 2021 • edited

rizzza commented Nov 16, 2021

codecov bot commented Nov 16, 2021 • edited

Codecov Report

joaopaulosr95 left a comment

Choose a reason for hiding this comment

smark88 commented Nov 16, 2021 • edited

Kampe commented Nov 16, 2021

alexmt commented Nov 17, 2021 • edited

smark88 commented Nov 16, 2021 •

edited

mfridman commented Nov 16, 2021 •

edited

codecov bot commented Nov 16, 2021 •

edited

smark88 commented Nov 16, 2021 •

edited

alexmt commented Nov 17, 2021 •

edited